Skip to content

[v1][KVCacheManager] Change prefix caching metric from counting blocks to counting tokens #18003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

heheda12345
Copy link
Collaborator

If hybrid allocator is introduced, it would be difficult to count the number of hit blocks as blocks will be organized in a complex data structure. To ensure the compatibility with prefix caching metrics, this PR changes the metrics to count the hit tokens. It should give very similar result to count the blocks.

Signed-off-by: Chen Zhang <zhangch99@outlook.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @markmc Please let us know if you have any concerns.

@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label May 12, 2025
@WoosukKwon WoosukKwon enabled auto-merge (squash) May 12, 2025 20:12
@WoosukKwon WoosukKwon disabled auto-merge May 12, 2025 20:46
@WoosukKwon WoosukKwon merged commit 302f3ac into vllm-project:main May 12, 2025
82 of 85 checks passed
@markmc
Copy link
Member

markmc commented May 13, 2025

LGTM. @markmc Please let us know if you have any concerns.

Short version - LGTM

Longer version - We added queries/hits in #12592 as a replacement for hit_rate in V0. See also here. I guess the hit rate should be the same whether based on blocks or tokens, so I assume there won't be any impact to any existing users.

mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
…s to counting tokens (vllm-project#18003)

Signed-off-by: Chen Zhang <zhangch99@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants