Skip to content

[Bugfix] Fix marlin moe fallback logic for llama4 #18042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented May 13, 2025

Introduces checks on FusedMoE specific configs like apply_router_weight_on_input or activation that certain kernels can't support.

Without this logic fix, running RedHatAI/Llama-4-Scout-17B-16E-Instruct-quantized.w4a16 will result in:

  File "/home/mgoin/code/vllm/vllm/model_executor/layers/fused_moe/layer.py", line 875, in forward_impl
    final_hidden_states = self.quant_method.apply(
                          ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/mgoin/code/vllm/vllm/model_executor/layers/quantization/compressed_tensors/compressed_tensors_moe.py", line 946, in apply
    raise NotImplementedError(
NotImplementedError: Apply router weight on input is not supported for fused Marlin MoE method.

Signed-off-by: mgoin <mgoin64@gmail.com>
@mgoin mgoin added this to the v0.9.0 milestone May 13, 2025
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mgoin mgoin added the bug Something isn't working label May 13, 2025
@mgoin mgoin changed the title Fix marlin moe fallback logic for llama4 [Bugfix] Fix marlin moe fallback logic for llama4 May 13, 2025
Signed-off-by: mgoin <mgoin64@gmail.com>
@mgoin mgoin requested a review from youkaichao as a code owner May 13, 2025 02:49
@simon-mo simon-mo enabled auto-merge (squash) May 13, 2025 04:10
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 13, 2025
@simon-mo simon-mo disabled auto-merge May 13, 2025 07:25
@simon-mo simon-mo enabled auto-merge (squash) May 13, 2025 07:25
@simon-mo simon-mo merged commit ea6ae8c into vllm-project:main May 13, 2025
95 checks passed
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@mgoin mgoin deleted the fix-marlin-moe-fallback-logic branch May 14, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants