Skip to content

[Doc] Update prefix cache metrics to counting tokens #18138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

heheda12345
Copy link
Collaborator

#18003 changes prefix caching metric from counting blocks to counting tokens. This PR updates the doc to sync with that PR.

Signed-off-by: Chen Zhang <zhangch99@outlook.com>
@mergify mergify bot added the documentation Improvements or additions to documentation label May 14, 2025
@heheda12345 heheda12345 requested a review from markmc May 14, 2025 12:15
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@markmc markmc added the v1 label May 14, 2025
@heheda12345 heheda12345 added the ready ONLY add when PR is ready to merge/full CI is needed label May 14, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 14, 2025 12:32
@DarkLight1337 DarkLight1337 merged commit 964472b into vllm-project:main May 14, 2025
44 of 46 checks passed
aarnphm pushed a commit to aarnphm/vllm that referenced this pull request May 15, 2025
)

Signed-off-by: Chen Zhang <zhangch99@outlook.com>
gshtras pushed a commit to ROCm/vllm that referenced this pull request May 15, 2025
)

Signed-off-by: Chen Zhang <zhangch99@outlook.com>
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants