Skip to content

[Frontend] Fix chat template content format detection #18190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

[Frontend] Fix chat template content format detection #18190

merged 1 commit into from
May 15, 2025

Conversation

schoennenbeck
Copy link
Contributor

@schoennenbeck schoennenbeck commented May 15, 2025 •
edited by github-actions bot
Loading

Fixes a logical error in the detection of the chat template content format which lead to a warning not being triggered even though it should be.

FIX #18189

@schoennenbeck
Fixed format detection
2c854cb 
Signed-off-by: Sebastian Schönnenbeck <sebastian.schoennenbeck@comma-soft.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the frontend label May 15, 2025
@schoennenbeck schoennenbeck changed the title Fixed format detection [Frontend] Fix chat template content format detection May 15, 2025
DarkLight1337
DarkLight1337 approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 15, 2025 13:38
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 15, 2025
@vllm-bot vllm-bot merged commit 2aa5470 into vllm-project:main May 15, 2025
69 of 71 checks passed
gshtras pushed a commit to ROCm/vllm that referenced this pull request May 15, 2025
@schoennenbeck @gshtras
[Frontend] Fix chat template content format detection (vllm-project#1…
daae930 
…8190)

Signed-off-by: Sebastian Schönnenbeck <sebastian.schoennenbeck@comma-soft.com>
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
frontend ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Logical error in resolve_chat_template_content_format
3 participants
@schoennenbeck @DarkLight1337 @vllm-bot