Skip to content

[Model] use AutoWeightsLoader for bloom #18300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Model] use AutoWeightsLoader for bloom #18300

wants to merge 1 commit into from
+37 −33

Conversation

calvin0327
Copy link
Contributor

@calvin0327 calvin0327 commented May 17, 2025 •
edited by github-actions bot
Loading

FIX (partial) #15697

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@lengrongfu
Copy link
Contributor

Thanks for working on this, there are some comments.

@calvin0327 calvin0327 force-pushed the autoweights-for-bloom branch from 0f255a3 to b3fca42 Compare May 17, 2025 09:41
@calvin0327
[Model] use AutoWeightsLoader for bloom
8ea1861 
Signed-off-by: calvin chen <120380290@qq.com>
@calvin0327 calvin0327 force-pushed the autoweights-for-bloom branch from b3fca42 to 8ea1861 Compare May 18, 2025 03:11
@calvin0327
Copy link
Contributor Author

@DarkLight1337 Thanks for the review，I have fixed these two errors.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 18, 2025 03:36
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 18, 2025
@DarkLight1337
Copy link
Member

Please fix the failing language models test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengrongfu lengrongfu lengrongfu left review comments

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calvin0327 @lengrongfu @DarkLight1337