Skip to content

[Bugfix][Model] Fix baichuan model loader for tp #18597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

MengqingCao
Copy link
Contributor

@MengqingCao MengqingCao commented May 23, 2025

Fix vllm-project/vllm-ascend#934, actually this issue is same on gpu

Fix baichuan model loader for tp. There is a customized lm_head_weight_loader in Baichuan, but it use default weight loader to load weights, this causes the above issue. This pr fix it by taking tensor parallel weight spilt into account.

Signed-off-by: Mengqing Cao <cmq0113@163.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 23, 2025 08:01
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 23, 2025
@vllm-bot vllm-bot merged commit 4ce64e2 into vllm-project:main May 23, 2025
63 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: vllm0.8.5rc1 run baichuan with TP,assert error
3 participants