-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
[bugfix] torch profiler bug for single gpu with GPUExecutor #8354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] torch profiler bug for single gpu with GPUExecutor #8354
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
/ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Different executor class for non-async case
Nice catch @njhill! I'm going to use type() to match on |
/ready |
ec866f3
to
e132dde
Compare
would be good to get a force merge @simon-mo @youkaichao |
Can you investigate whether the failure in LLaVA test is related to your changes?
|
…ject#8354) Signed-off-by: Alvant <alvasian@yandex.ru>
…ject#8354) Signed-off-by: Amit Garg <mitgarg17495@gmail.com>
…ject#8354) Signed-off-by: LeiWang1999 <leiwang1999@outlook.com>
GPUExecutor has a different API and does not define a
_run_workers
.Another way to fix this would be define the
_run_workers
(it would only call the driver_worker) api inGPUExecutor
to match the API of the other executors. That will avoid the extra import..closes #8326 and closes #8351