Skip to content

[Bugfix] Fix async log stats #8417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 13, 2024
Merged

[Bugfix] Fix async log stats #8417

merged 3 commits into from
Sep 13, 2024

Conversation

alexm-redhat
Copy link
Collaborator

This PR fixes the issue described here: #8219 (comment)

The fix is simple, we need to skip log stats for sequences that are already preempted since their state is reset to PREFILL (for recompute).

@alexm-redhat
Copy link
Collaborator Author

/ready

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@alexm-redhat alexm-redhat mentioned this pull request Sep 12, 2024
Closed
1 task
@DarkLight1337
Copy link
Member

Does it fix #8178?

@alexm-redhat
Copy link
Collaborator Author

alexm-redhat commented Sep 12, 2024 •
edited
Loading

@DarkLight1337 not sure if it is related to #8178.

@alexm-redhat
Copy link
Collaborator Author

@robertgshaw2-neuralmagic @comaniac

comaniac
comaniac approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@comaniac comaniac enabled auto-merge (squash) September 12, 2024 16:15
@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 12, 2024
@simon-mo simon-mo mentioned this pull request Sep 12, 2024
Closed
7 tasks
auto-merge was automatically disabled September 12, 2024 18:50

Head branch was pushed to by a user without write access

mgoin
mgoin approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would call it preempted_indices but it seems like this could be used for other uses in the future

@simon-mo simon-mo merged commit 6821020 into vllm-project:main Sep 13, 2024
48 of 50 checks passed
@ashgold
Copy link

ashgold commented Sep 23, 2024

Does it fix #8178?

Some of this has been resolved, but when applying the --num-scheduler-steps option, the values are not realistic for some metrics.

Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@alexm-redhat @Alvant
[Bugfix] Fix async log stats (vllm-project#8417)
6b30dd5 
Signed-off-by: Alvant <alvasian@yandex.ru>
DwyaneShi pushed a commit to aibrix/vllm that referenced this pull request Dec 6, 2024
@alexm-redhat
[Bugfix] Fix async log stats (vllm-project#8417)
ea54daf
@DwyaneShi DwyaneShi mentioned this pull request Dec 6, 2024
Merged
DwyaneShi added a commit to aibrix/vllm that referenced this pull request Dec 12, 2024
@DwyaneShi @alexm-redhat
[Bugfix] Fix async log stats (vllm-project#8417) (#17)
279175d 
Co-authored-by: Alexander Matveev <59768536+alexm-neuralmagic@users.noreply.github.com>
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
@alexm-redhat @LeiWang1999
[Bugfix] Fix async log stats (vllm-project#8417)
2df5e25 
Signed-off-by: LeiWang1999 <leiwang1999@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin mgoin approved these changes

@comaniac comaniac comaniac approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexm-redhat @DarkLight1337 @ashgold @mgoin @comaniac @simon-mo