Skip to content

[Bugfix] multi-step + flashinfer: ensure cuda graph compatible #8427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

alexm-redhat
Copy link
Collaborator

This PR ports multi-step cuda graph block table fix from the flash_attn backend to flashinfer backend

@alexm-redhat
Copy link
Collaborator Author

/ready

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@alexm-redhat
Copy link
Collaborator Author

@robertgshaw2-neuralmagic @SolitaryThinker @comaniac

@alexm-redhat alexm-redhat changed the title [Bugfix] Ensure cuda graph compatible multi-step + flashinfer [Bugfix] multi-step + flashinfer: Ensure cuda graph compatible Sep 12, 2024
@alexm-redhat alexm-redhat changed the title [Bugfix] multi-step + flashinfer: Ensure cuda graph compatible [Bugfix] Multi-step + Flashinfer: Ensure cuda graph compatible Sep 12, 2024
@alexm-redhat alexm-redhat changed the title [Bugfix] Multi-step + Flashinfer: Ensure cuda graph compatible [Bugfix] multi-step + flashinfer: ensure cuda graph compatible Sep 12, 2024
@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 12, 2024
@comaniac comaniac enabled auto-merge (squash) September 12, 2024 18:48
@comaniac comaniac merged commit 0198772 into vllm-project:main Sep 12, 2024
63 checks passed
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants