Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: multiple gitcoin passport downloads at the same time #195

Closed
lucasmenendez opened this issue Apr 12, 2024 · 0 comments · Fixed by #196
Closed

bug: multiple gitcoin passport downloads at the same time #195

lucasmenendez opened this issue Apr 12, 2024 · 0 comments · Fixed by #196
Assignees
Labels
bug Something isn't working

Comments

@lucasmenendez
Copy link
Collaborator

Describe the bug
Every gitcoin token downloads its own version of the whole database, including the rest of the stamps.

Current behavior
Every stamp from gitcoin works as an individual token for the scanner. Until the last changes in the scanner, every token shares the same instance of a HolderProvider, which fits perfectly with the gitcoin use case.

The gitcoin holder provider, when inits, start to download the latest scores and updates its internal database to be ready to be query by the scanner. Unfortunately, since the scanner can scan multiples tokens concurrently, the tokens do not share holder providers any more, which produces multiple gitcoin downloads concurrently

Expected behavior
The download of the latest scores must be atomic between tokens of gitcoinspassport type, it can be achieved in multiple layers of the service:

  • scanner/providers/manager: Introducing some exceptions for certain providers such as the gitcoinpassport
  • scanner/providers/gitcoin: Introducing some logic to manage blocking download between instances.
@lucasmenendez lucasmenendez added the bug Something isn't working label Apr 12, 2024
@lucasmenendez lucasmenendez self-assigned this Apr 12, 2024
@lucasmenendez lucasmenendez linked a pull request Apr 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant