Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: multiple gitcoin downloads #196

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Conversation

lucasmenendez
Copy link
Collaborator

including an atomic var to handle multiple concurrent gitcoin providers, including global context into the providers to handle shutdown gracefully

Fix #195

…rs, including global context into the providers to handle shutdown gracefully
@lucasmenendez lucasmenendez added the bug Something isn't working label Apr 12, 2024
@lucasmenendez lucasmenendez requested a review from p4u April 12, 2024 09:09
@lucasmenendez lucasmenendez self-assigned this Apr 12, 2024
@lucasmenendez lucasmenendez linked an issue Apr 12, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Apr 12, 2024

Image description CodeRabbit


Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 63f7188 and 1b07463 commits.
Files selected (12)
  • cmd/census3/main.go (1)
  • scanner/providers/farcaster/provider.go (3)
  • scanner/providers/gitcoin/gitcoin_provider.go (8)
  • scanner/providers/gitcoin/gitcoin_provider_test.go (2)
  • scanner/providers/holders_provider.go (1)
  • scanner/providers/manager/manager.go (4)
  • scanner/providers/poap/poap_provider.go (4)
  • scanner/providers/poap/poap_provider_test.go (1)
  • scanner/providers/web3/erc20_provider.go (1)
  • scanner/providers/web3/erc721_provider.go (1)
  • scanner/providers/web3/erc777_provider.go (1)
  • scanner/scanner.go (1)
Files not summarized due to errors (12)
  • cmd/census3/main.go (nothing obtained from openai)
  • scanner/providers/farcaster/provider.go (nothing obtained from openai)
  • scanner/providers/holders_provider.go (nothing obtained from openai)
  • scanner/providers/gitcoin/gitcoin_provider_test.go (nothing obtained from openai)
  • scanner/providers/gitcoin/gitcoin_provider.go (nothing obtained from openai)
  • scanner/providers/manager/manager.go (nothing obtained from openai)
  • scanner/providers/web3/erc777_provider.go (nothing obtained from openai)
  • scanner/providers/web3/erc20_provider.go (nothing obtained from openai)
  • scanner/providers/poap/poap_provider_test.go (nothing obtained from openai)
  • scanner/providers/poap/poap_provider.go (nothing obtained from openai)
  • scanner/providers/web3/erc721_provider.go (nothing obtained from openai)
  • scanner/scanner.go (nothing obtained from openai)
Files not reviewed due to errors (12)
  • cmd/census3/main.go (no response)
  • scanner/providers/manager/manager.go (no response)
  • scanner/providers/farcaster/provider.go (no response)
  • scanner/providers/gitcoin/gitcoin_provider_test.go (no response)
  • scanner/providers/gitcoin/gitcoin_provider.go (no response)
  • scanner/providers/holders_provider.go (no response)
  • scanner/providers/web3/erc20_provider.go (no response)
  • scanner/providers/poap/poap_provider_test.go (no response)
  • scanner/providers/web3/erc777_provider.go (no response)
  • scanner/scanner.go (no response)
  • scanner/providers/poap/poap_provider.go (no response)
  • scanner/providers/web3/erc721_provider.go (no response)
Review comments generated (0)
  • Review: 0
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 1b07463 and 9461b1d commits.
Files selected (2)
  • scanner/providers/gitcoin/gitcoin_provider.go (8)
  • scanner/providers/poap/poap_provider.go (6)
Files not summarized due to errors (2)
  • scanner/providers/poap/poap_provider.go (nothing obtained from openai)
  • scanner/providers/gitcoin/gitcoin_provider.go (nothing obtained from openai)
Files not reviewed due to errors (2)
  • scanner/providers/gitcoin/gitcoin_provider.go (no response)
  • scanner/providers/poap/poap_provider.go (no response)
Review comments generated (0)
  • Review: 0
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@lucasmenendez lucasmenendez merged commit a5b297f into main Apr 12, 2024
7 checks passed
@lucasmenendez lucasmenendez deleted the b/multiple_gitcoin_downloads branch April 12, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: multiple gitcoin passport downloads at the same time
1 participant