Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enforce gofumpt instead of gofmt #1236

Merged
merged 2 commits into from
Jun 20, 2024
Merged

ci: enforce gofumpt instead of gofmt #1236

merged 2 commits into from
Jun 20, 2024

Conversation

altergui
Copy link
Contributor

@altergui altergui commented Jan 9, 2024

No description provided.

@coveralls
Copy link

coveralls commented Jan 9, 2024

Pull Request Test Coverage Report for Build 9595515452

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 89 of 107 (83.18%) changed or added relevant lines in 29 files are covered.
  • 5 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.05%) to 61.364%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apiclient/blockchain.go 0 1 0.0%
apiclient/election.go 2 3 66.67%
data/ipfs/init.go 1 2 50.0%
log/log.go 0 1 0.0%
test/testcommon/testvoteproof/voteproof.go 5 6 83.33%
apiclient/account.go 4 6 66.67%
db/internal/dbtest/dbtest.go 0 2 0.0%
subpub/subpub.go 0 2 0.0%
vochain/cometbft.go 5 8 62.5%
api/wallet.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
cmd/end2endtest/dynamicensus.go 1 77.33%
subpub/subpub.go 1 0.0%
vochain/start.go 1 71.96%
vochain/indexer/indexer.go 2 67.9%
Totals Coverage Status
Change from base Build 9595431203: 0.05%
Covered Lines: 16011
Relevant Lines: 26092

💛 - Coveralls

@altergui altergui force-pushed the feat/ci-gofumpt branch 2 times, most recently from 7009c83 to 27d99bc Compare January 9, 2024 16:23
@altergui altergui requested review from p4u and mvdan March 6, 2024 15:07
@altergui
Copy link
Contributor Author

altergui commented Mar 6, 2024

finally all pending PRs are merged (the only ones left are draft PRs, all mine) so i'd approve & merge this one

@p4u
Copy link
Member

p4u commented Jun 16, 2024

fix conflicts please and we can merge it @altergui

@altergui
Copy link
Contributor Author

altergui commented Jun 18, 2024

fix conflicts please and we can merge it @altergui

🤥

please approve, and i'll take care of merging (just in case there are conflicts, so i can solve them before merging)

@altergui altergui merged commit 59aa664 into main Jun 20, 2024
13 checks passed
@altergui altergui deleted the feat/ci-gofumpt branch June 20, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants