Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add official support for Python 3.13 #113

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

jairhenrique
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.37%. Comparing base (2b71787) to head (057077a).
Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   99.72%   98.37%   -1.36%     
==========================================
  Files          10       14       +4     
  Lines         362      430      +68     
==========================================
+ Hits          361      423      +62     
- Misses          1        7       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jairhenrique,

As much as I share your enthusiasm about Python 3.13, don't see a strong need to introduce pre-releases here. I am fine waiting for GitHub to catch up. Besides, almost all Python versions are forward compatible. So if you want to use Python 3.13, go ahead. The package will install and work.

You are welcome to update this, once GitHub actions officially support 3.13.

Best,
-Joe

@jairhenrique jairhenrique changed the title Run tests on python 3.13 Add official support for Python 3.13 Oct 15, 2024
@jairhenrique
Copy link
Contributor Author

@codingjoe GitHub already supports Python 3.13. I usually add allow-prereleases: true to facilitate future releases.

I removed this parameter from CI and the tests continue to work!

@codingjoe codingjoe enabled auto-merge (squash) October 18, 2024 14:59
Copy link
Member

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jairhenrique

@codingjoe codingjoe merged commit 4479a3c into voiio:main Oct 18, 2024
17 of 18 checks passed
@jairhenrique jairhenrique deleted the python313 branch October 18, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants