Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: slack link on contribution page #367

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: slack link on contribution page #367

wants to merge 1 commit into from

Conversation

jaiakash
Copy link

@jaiakash jaiakash commented Feb 22, 2025 •
edited
Loading

  • The commit message follows our guidelines

@volcano-sh-bot
Copy link
Collaborator

Welcome @jaiakash!

It looks like this is your first PR to volcano-sh/website.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 22, 2025
@volcano-sh-bot volcano-sh-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 22, 2025
@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign k82cn
You can assign the PR to them by writing /assign @k82cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 22, 2025
@jaiakash jaiakash force-pushed the slack-link-fix branch 2 times, most recently from 505f48c to 30a1513 Compare February 22, 2025 04:58
@jaiakash
fix: extra line height and slack channel link
10036ab 
Signed-off-by: Akash Jaiswal <akashjaiswal3846@gmail.com>
Arhell
Arhell reviewed Feb 23, 2025
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2025
@Arhell Arhell removed their assignment Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@william-wang william-wang Awaiting requested review from william-wang

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: add slack link at contribution page remove unnecessary line-height
3 participants
@jaiakash @volcano-sh-bot @Arhell