Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggested style for the page #359

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Suggested style for the page #359

wants to merge 1 commit into from

Conversation

Shrutim1505
Copy link
Contributor

@Shrutim1505 Shrutim1505 commented Feb 15, 2025 •
edited
Loading

image

I guess it looks better in preview

@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign william-wang
You can assign the PR to them by writing /assign @william-wang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 15, 2025
@Shrutim1505
fixed docs alignment in mobile view
a5bdade 
Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com>

fixed docs alignment in mobile view

Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com>

fixed docs alignment in mobile view

Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com>

fixed responsiveness

Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com>

 layout/fix

Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com>

code updation

Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com>

remove extra padding

Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com>

change background colour

Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com>
@Shrutim1505
Copy link
Contributor Author

/assign @william-wang

@Shrutim1505
Copy link
Contributor Author

Shrutim1505 commented Feb 15, 2025 •
edited
Loading

@Arhell @kevin-wangzefeng @Monokaix check this one

@Shrutim1505 Shrutim1505 mentioned this pull request Feb 15, 2025
Closed
@Monokaix
Copy link
Member

It seems grayer.

Arhell
Arhell reviewed Feb 17, 2025
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shrutim1505 the same problem as described here #358 (comment)

@Shrutim1505
Copy link
Contributor Author

@Arhell ok I will remember it next time.

@Shrutim1505
Copy link
Contributor Author

@Arhell @Monokaix is this change viable??

@Arhell
Copy link
Member

Arhell commented Feb 17, 2025

I don't see the point in this change, except maybe the shadow could be increased a bit in these blocks.

and don't forget about testing

1

@Shrutim1505
Copy link
Contributor Author

I don't see the point in this change, except maybe the shadow could be increased a bit in these blocks.

and don't forget about testing

1

ok

@Arhell
Copy link
Member

Arhell commented Feb 17, 2025

Just in case, maybe you didn't know Preview here
1

but not all projects have this.

@Shrutim1505 Shrutim1505 marked this pull request as draft February 17, 2025 12:54
@Shrutim1505
Copy link
Contributor Author

Shrutim1505 commented Feb 17, 2025 •
edited
Loading

Just in case, maybe you didn't know Preview here 1

but not all projects have this.

Ok @Arhell
I have seen the deployed link. However, I feel changes are not reliable.
I would have a better approach to this then.
Thanks for correcting me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

At least 1 approving review is required to merge this pull request.

Assignees

@william-wang william-wang

Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Shrutim1505 @volcano-sh-bot @Monokaix @Arhell @william-wang