Refactor toast window #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mgefimov hello and sorry for forgetting to review this! Just so it's clear to me - this is just a refactor, so the goal is to do the same thing with less code, do I understand it right? Thank you! |
|
@vonovak Hello again! Yeah, you're right, it's just a refactor. Nothing has changed except the code. |
|
hello, there's a change in behavior for the "toast in alert" example, as seen in the video. It's expected that the toast remains visible. RocketSim_Recording_iPhone_15_Pro_Max_6.7_2024-02-22_11.18.48.mp4 |
|
@vonovak Thank you for the review! I have fixed it. |
mgefimov
force-pushed
the
refactor-toast-window
branch
from
b2f3e84 to
1f221e2
Compare
|
thank you! Or if you want to explain in words, that's also fine :) |
|
Yeah, I'll split the changes into two commits |
mgefimov
force-pushed
the
refactor-toast-window
branch
from
1f221e2 to
2dabe1c
Compare
|
@vonovak Done |
|
thank you! :) |
vonovak
added a commit
that referenced
this pull request
Mar 20, 2024
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
Apr 27, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-simple-toast](https://togithub.com/vonovak/react-native-simple-toast) | [`^1.1.4` -> `^3.3.1`](https://renovatebot.com/diffs/npm/react-native-simple-toast/1.1.4/3.3.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vonovak/react-native-simple-toast (react-native-simple-toast)</summary> ### [`v3.3.1`](https://togithub.com/vonovak/react-native-simple-toast/releases/tag/v3.3.1) [Compare Source](https://togithub.com/vonovak/react-native-simple-toast/compare/v3.3.0...v3.3.1) #### What's Changed - Revert "Refactor toast window" by [@​vonovak](https://togithub.com/vonovak) in [https://github.com/vonovak/react-native-simple-toast/pull/78](https://togithub.com/vonovak/react-native-simple-toast/pull/78) **Full Changelog**: vonovak/react-native-simple-toast@v3.3.0...v3.3.1 ### [`v3.3.0`](https://togithub.com/vonovak/react-native-simple-toast/releases/tag/v3.3.0) [Compare Source](https://togithub.com/vonovak/react-native-simple-toast/compare/v3.2.0...v3.3.0) #### What's Changed - chore(deps): bump ip from 1.1.8 to 1.1.9 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/75](https://togithub.com/vonovak/react-native-simple-toast/pull/75) - chore(deps): bump ip from 1.1.8 to 1.1.9 in /example by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/76](https://togithub.com/vonovak/react-native-simple-toast/pull/76) - Refactor toast window by [@​mgefimov](https://togithub.com/mgefimov) in [https://github.com/vonovak/react-native-simple-toast/pull/74](https://togithub.com/vonovak/react-native-simple-toast/pull/74) **Full Changelog**: vonovak/react-native-simple-toast@v3.2.0...v3.3.0 ### [`v3.2.0`](https://togithub.com/vonovak/react-native-simple-toast/releases/tag/v3.2.0): Release 3.2.0 [Compare Source](https://togithub.com/vonovak/react-native-simple-toast/compare/v3.1.0...v3.2.0) #### What's Changed - feat: keyboard avoid by [@​mgefimov](https://togithub.com/mgefimov) in [https://github.com/vonovak/react-native-simple-toast/pull/73](https://togithub.com/vonovak/react-native-simple-toast/pull/73) **Full Changelog**: vonovak/react-native-simple-toast@v3.1.0...v3.2.0 ### [`v3.1.0`](https://togithub.com/vonovak/react-native-simple-toast/releases/tag/v3.1.0) [Compare Source](https://togithub.com/vonovak/react-native-simple-toast/compare/v3.0.2...v3.1.0) #### What's Changed - Tap to dismiss by [@​mgefimov](https://togithub.com/mgefimov) in [https://github.com/vonovak/react-native-simple-toast/pull/64](https://togithub.com/vonovak/react-native-simple-toast/pull/64) - refactor: minor changes to types by [@​vonovak](https://togithub.com/vonovak) in [https://github.com/vonovak/react-native-simple-toast/pull/72](https://togithub.com/vonovak/react-native-simple-toast/pull/72) - chore(deps): bump [@​babel/traverse](https://togithub.com/babel/traverse) from 7.22.8 to 7.23.2 in /example by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/65](https://togithub.com/vonovak/react-native-simple-toast/pull/65) - chore(deps): bump [@​babel/traverse](https://togithub.com/babel/traverse) from 7.22.8 to 7.23.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/66](https://togithub.com/vonovak/react-native-simple-toast/pull/66) - chore(deps): bump react-devtools-core from 4.28.0 to 4.28.4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/68](https://togithub.com/vonovak/react-native-simple-toast/pull/68) - chore(deps): bump react-devtools-core from 4.28.0 to 4.28.4 in /example by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/67](https://togithub.com/vonovak/react-native-simple-toast/pull/67) - chore: update ci.yml by [@​vonovak](https://togithub.com/vonovak) in [https://github.com/vonovak/react-native-simple-toast/pull/70](https://togithub.com/vonovak/react-native-simple-toast/pull/70) **Full Changelog**: vonovak/react-native-simple-toast@v3.0.2...v3.1.0 ### [`v3.0.2`](https://togithub.com/vonovak/react-native-simple-toast/releases/tag/v3.0.2): Release 3.0.2 [Compare Source](https://togithub.com/vonovak/react-native-simple-toast/compare/v3.0.1...v3.0.2) #### What's Changed - refactor: remove view controller by [@​mgefimov](https://togithub.com/mgefimov) in [https://github.com/vonovak/react-native-simple-toast/pull/63](https://togithub.com/vonovak/react-native-simple-toast/pull/63) #### New Contributors - [@​mgefimov](https://togithub.com/mgefimov) made their first contribution in [https://github.com/vonovak/react-native-simple-toast/pull/63](https://togithub.com/vonovak/react-native-simple-toast/pull/63) **Full Changelog**: vonovak/react-native-simple-toast@v3.0.1...v3.0.2 ### [`v3.0.1`](https://togithub.com/vonovak/react-native-simple-toast/releases/tag/v3.0.1) [Compare Source](https://togithub.com/vonovak/react-native-simple-toast/compare/v3.0.0...v3.0.1) #### What's Changed - fix: update how toastWindow is obtained by [@​vonovak](https://togithub.com/vonovak) in [https://github.com/vonovak/react-native-simple-toast/pull/58](https://togithub.com/vonovak/react-native-simple-toast/pull/58) **Full Changelog**: vonovak/react-native-simple-toast@v3.0.0...v3.0.1 ### [`v3.0.0`](https://togithub.com/vonovak/react-native-simple-toast/releases/tag/v3.0.0) [Compare Source](https://togithub.com/vonovak/react-native-simple-toast/compare/v2.0.1...v3.0.0) #### What's Changed - feat: support old arch as well by [@​vonovak](https://togithub.com/vonovak) in [https://github.com/vonovak/react-native-simple-toast/pull/55](https://togithub.com/vonovak/react-native-simple-toast/pull/55) no breaking changes **Full Changelog**: vonovak/react-native-simple-toast@v2.0.1...v3.0.0 ### [`v2.0.1`](https://togithub.com/vonovak/react-native-simple-toast/releases/tag/v2.0.1) [Compare Source](https://togithub.com/vonovak/react-native-simple-toast/compare/v2.0.0...v2.0.1) #### What's Changed - Toast.show default duration is added by [@​adsalihac](https://togithub.com/adsalihac) in [https://github.com/vonovak/react-native-simple-toast/pull/51](https://togithub.com/vonovak/react-native-simple-toast/pull/51) - docs: add summary docs by [@​vonovak](https://togithub.com/vonovak) in [https://github.com/vonovak/react-native-simple-toast/pull/26](https://togithub.com/vonovak/react-native-simple-toast/pull/26) - docs: clarify old arch by [@​vonovak](https://togithub.com/vonovak) in [https://github.com/vonovak/react-native-simple-toast/pull/28](https://togithub.com/vonovak/react-native-simple-toast/pull/28) - Bump json5 from 2.2.1 to 2.2.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/33](https://togithub.com/vonovak/react-native-simple-toast/pull/33) - docs: add new arch link by [@​vonovak](https://togithub.com/vonovak) in [https://github.com/vonovak/react-native-simple-toast/pull/35](https://togithub.com/vonovak/react-native-simple-toast/pull/35) - Bump http-cache-semantics from 4.1.0 to 4.1.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/36](https://togithub.com/vonovak/react-native-simple-toast/pull/36) - Bump cacheable-request from 10.2.3 to 10.2.7 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/37](https://togithub.com/vonovak/react-native-simple-toast/pull/37) - Update issue templates by [@​vonovak](https://togithub.com/vonovak) in [https://github.com/vonovak/react-native-simple-toast/pull/41](https://togithub.com/vonovak/react-native-simple-toast/pull/41) - Bump vm2 from 3.9.12 to 3.9.15 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/44](https://togithub.com/vonovak/react-native-simple-toast/pull/44) - Bump vm2 from 3.9.15 to 3.9.16 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/45](https://togithub.com/vonovak/react-native-simple-toast/pull/45) - Bump vm2 from 3.9.16 to 3.9.17 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/46](https://togithub.com/vonovak/react-native-simple-toast/pull/46) - Bump [@​sideway/formula](https://togithub.com/sideway/formula) from 3.0.0 to 3.0.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/48](https://togithub.com/vonovak/react-native-simple-toast/pull/48) - Bump [@​sideway/formula](https://togithub.com/sideway/formula) from 3.0.0 to 3.0.1 in /example by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/47](https://togithub.com/vonovak/react-native-simple-toast/pull/47) - Bump vm2 from 3.9.17 to 3.9.18 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/50](https://togithub.com/vonovak/react-native-simple-toast/pull/50) #### New Contributors - [@​dependabot](https://togithub.com/dependabot) made their first contribution in [https://github.com/vonovak/react-native-simple-toast/pull/33](https://togithub.com/vonovak/react-native-simple-toast/pull/33) - [@​adsalihac](https://togithub.com/adsalihac) made their first contribution in [https://github.com/vonovak/react-native-simple-toast/pull/51](https://togithub.com/vonovak/react-native-simple-toast/pull/51) **Full Changelog**: vonovak/react-native-simple-toast@v2.0.0...v2.0.1 ### [`v2.0.0`](https://togithub.com/vonovak/react-native-simple-toast/releases/tag/v2.0.0) [Compare Source](https://togithub.com/vonovak/react-native-simple-toast/compare/v1.1.4...v2.0.0) #### What's Changed - new architecture migration - rewritten toast presentation logic PR: [https://github.com/vonovak/react-native-simple-toast/pull/25](https://togithub.com/vonovak/react-native-simple-toast/pull/25) BREAKING: new arch is now **required** **Full Changelog**: vonovak/react-native-simple-toast@v1.1.4...v2.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
shottah
referenced
this pull request
in zed-io/kolektivo
May 15, 2024
](https://renovatebot.com){kind=link}
…inc#5353) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-simple-toast](https://togithub.com/vonovak/react-native-simple-toast) | [`^1.1.4` -> `^3.3.1`](https://renovatebot.com/diffs/npm/react-native-simple-toast/1.1.4/3.3.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vonovak/react-native-simple-toast (react-native-simple-toast)</summary> ### [`v3.3.1`](https://togithub.com/vonovak/react-native-simple-toast/releases/tag/v3.3.1) [Compare Source](https://togithub.com/vonovak/react-native-simple-toast/compare/v3.3.0...v3.3.1) #### What's Changed - Revert "Refactor toast window" by [@​vonovak](https://togithub.com/vonovak) in [https://github.com/vonovak/react-native-simple-toast/pull/78](https://togithub.com/vonovak/react-native-simple-toast/pull/78) **Full Changelog**: vonovak/react-native-simple-toast@v3.3.0...v3.3.1 ### [`v3.3.0`](https://togithub.com/vonovak/react-native-simple-toast/releases/tag/v3.3.0) [Compare Source](https://togithub.com/vonovak/react-native-simple-toast/compare/v3.2.0...v3.3.0) #### What's Changed - chore(deps): bump ip from 1.1.8 to 1.1.9 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/75](https://togithub.com/vonovak/react-native-simple-toast/pull/75) - chore(deps): bump ip from 1.1.8 to 1.1.9 in /example by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/76](https://togithub.com/vonovak/react-native-simple-toast/pull/76) - Refactor toast window by [@​mgefimov](https://togithub.com/mgefimov) in [https://github.com/vonovak/react-native-simple-toast/pull/74](https://togithub.com/vonovak/react-native-simple-toast/pull/74) **Full Changelog**: vonovak/react-native-simple-toast@v3.2.0...v3.3.0 ### [`v3.2.0`](https://togithub.com/vonovak/react-native-simple-toast/releases/tag/v3.2.0): Release 3.2.0 [Compare Source](https://togithub.com/vonovak/react-native-simple-toast/compare/v3.1.0...v3.2.0) #### What's Changed - feat: keyboard avoid by [@​mgefimov](https://togithub.com/mgefimov) in [https://github.com/vonovak/react-native-simple-toast/pull/73](https://togithub.com/vonovak/react-native-simple-toast/pull/73) **Full Changelog**: vonovak/react-native-simple-toast@v3.1.0...v3.2.0 ### [`v3.1.0`](https://togithub.com/vonovak/react-native-simple-toast/releases/tag/v3.1.0) [Compare Source](https://togithub.com/vonovak/react-native-simple-toast/compare/v3.0.2...v3.1.0) #### What's Changed - Tap to dismiss by [@​mgefimov](https://togithub.com/mgefimov) in [https://github.com/vonovak/react-native-simple-toast/pull/64](https://togithub.com/vonovak/react-native-simple-toast/pull/64) - refactor: minor changes to types by [@​vonovak](https://togithub.com/vonovak) in [https://github.com/vonovak/react-native-simple-toast/pull/72](https://togithub.com/vonovak/react-native-simple-toast/pull/72) - chore(deps): bump [@​babel/traverse](https://togithub.com/babel/traverse) from 7.22.8 to 7.23.2 in /example by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/65](https://togithub.com/vonovak/react-native-simple-toast/pull/65) - chore(deps): bump [@​babel/traverse](https://togithub.com/babel/traverse) from 7.22.8 to 7.23.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/66](https://togithub.com/vonovak/react-native-simple-toast/pull/66) - chore(deps): bump react-devtools-core from 4.28.0 to 4.28.4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/68](https://togithub.com/vonovak/react-native-simple-toast/pull/68) - chore(deps): bump react-devtools-core from 4.28.0 to 4.28.4 in /example by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/67](https://togithub.com/vonovak/react-native-simple-toast/pull/67) - chore: update ci.yml by [@​vonovak](https://togithub.com/vonovak) in [https://github.com/vonovak/react-native-simple-toast/pull/70](https://togithub.com/vonovak/react-native-simple-toast/pull/70) **Full Changelog**: vonovak/react-native-simple-toast@v3.0.2...v3.1.0 ### [`v3.0.2`](https://togithub.com/vonovak/react-native-simple-toast/releases/tag/v3.0.2): Release 3.0.2 [Compare Source](https://togithub.com/vonovak/react-native-simple-toast/compare/v3.0.1...v3.0.2) #### What's Changed - refactor: remove view controller by [@​mgefimov](https://togithub.com/mgefimov) in [https://github.com/vonovak/react-native-simple-toast/pull/63](https://togithub.com/vonovak/react-native-simple-toast/pull/63) #### New Contributors - [@​mgefimov](https://togithub.com/mgefimov) made their first contribution in [https://github.com/vonovak/react-native-simple-toast/pull/63](https://togithub.com/vonovak/react-native-simple-toast/pull/63) **Full Changelog**: vonovak/react-native-simple-toast@v3.0.1...v3.0.2 ### [`v3.0.1`](https://togithub.com/vonovak/react-native-simple-toast/releases/tag/v3.0.1) [Compare Source](https://togithub.com/vonovak/react-native-simple-toast/compare/v3.0.0...v3.0.1) #### What's Changed - fix: update how toastWindow is obtained by [@​vonovak](https://togithub.com/vonovak) in [https://github.com/vonovak/react-native-simple-toast/pull/58](https://togithub.com/vonovak/react-native-simple-toast/pull/58) **Full Changelog**: vonovak/react-native-simple-toast@v3.0.0...v3.0.1 ### [`v3.0.0`](https://togithub.com/vonovak/react-native-simple-toast/releases/tag/v3.0.0) [Compare Source](https://togithub.com/vonovak/react-native-simple-toast/compare/v2.0.1...v3.0.0) #### What's Changed - feat: support old arch as well by [@​vonovak](https://togithub.com/vonovak) in [https://github.com/vonovak/react-native-simple-toast/pull/55](https://togithub.com/vonovak/react-native-simple-toast/pull/55) no breaking changes **Full Changelog**: vonovak/react-native-simple-toast@v2.0.1...v3.0.0 ### [`v2.0.1`](https://togithub.com/vonovak/react-native-simple-toast/releases/tag/v2.0.1) [Compare Source](https://togithub.com/vonovak/react-native-simple-toast/compare/v2.0.0...v2.0.1) #### What's Changed - Toast.show default duration is added by [@​adsalihac](https://togithub.com/adsalihac) in [https://github.com/vonovak/react-native-simple-toast/pull/51](https://togithub.com/vonovak/react-native-simple-toast/pull/51) - docs: add summary docs by [@​vonovak](https://togithub.com/vonovak) in [https://github.com/vonovak/react-native-simple-toast/pull/26](https://togithub.com/vonovak/react-native-simple-toast/pull/26) - docs: clarify old arch by [@​vonovak](https://togithub.com/vonovak) in [https://github.com/vonovak/react-native-simple-toast/pull/28](https://togithub.com/vonovak/react-native-simple-toast/pull/28) - Bump json5 from 2.2.1 to 2.2.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/33](https://togithub.com/vonovak/react-native-simple-toast/pull/33) - docs: add new arch link by [@​vonovak](https://togithub.com/vonovak) in [https://github.com/vonovak/react-native-simple-toast/pull/35](https://togithub.com/vonovak/react-native-simple-toast/pull/35) - Bump http-cache-semantics from 4.1.0 to 4.1.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/36](https://togithub.com/vonovak/react-native-simple-toast/pull/36) - Bump cacheable-request from 10.2.3 to 10.2.7 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/37](https://togithub.com/vonovak/react-native-simple-toast/pull/37) - Update issue templates by [@​vonovak](https://togithub.com/vonovak) in [https://github.com/vonovak/react-native-simple-toast/pull/41](https://togithub.com/vonovak/react-native-simple-toast/pull/41) - Bump vm2 from 3.9.12 to 3.9.15 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/44](https://togithub.com/vonovak/react-native-simple-toast/pull/44) - Bump vm2 from 3.9.15 to 3.9.16 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/45](https://togithub.com/vonovak/react-native-simple-toast/pull/45) - Bump vm2 from 3.9.16 to 3.9.17 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/46](https://togithub.com/vonovak/react-native-simple-toast/pull/46) - Bump [@​sideway/formula](https://togithub.com/sideway/formula) from 3.0.0 to 3.0.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/48](https://togithub.com/vonovak/react-native-simple-toast/pull/48) - Bump [@​sideway/formula](https://togithub.com/sideway/formula) from 3.0.0 to 3.0.1 in /example by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/47](https://togithub.com/vonovak/react-native-simple-toast/pull/47) - Bump vm2 from 3.9.17 to 3.9.18 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vonovak/react-native-simple-toast/pull/50](https://togithub.com/vonovak/react-native-simple-toast/pull/50) #### New Contributors - [@​dependabot](https://togithub.com/dependabot) made their first contribution in [https://github.com/vonovak/react-native-simple-toast/pull/33](https://togithub.com/vonovak/react-native-simple-toast/pull/33) - [@​adsalihac](https://togithub.com/adsalihac) made their first contribution in [https://github.com/vonovak/react-native-simple-toast/pull/51](https://togithub.com/vonovak/react-native-simple-toast/pull/51) **Full Changelog**: vonovak/react-native-simple-toast@v2.0.0...v2.0.1 ### [`v2.0.0`](https://togithub.com/vonovak/react-native-simple-toast/releases/tag/v2.0.0) [Compare Source](https://togithub.com/vonovak/react-native-simple-toast/compare/v1.1.4...v2.0.0) #### What's Changed - new architecture migration - rewritten toast presentation logic PR: [https://github.com/vonovak/react-native-simple-toast/pull/25](https://togithub.com/vonovak/react-native-simple-toast/pull/25) BREAKING: new arch is now **required** **Full Changelog**: vonovak/react-native-simple-toast@v1.1.4...v2.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've refactored the toast window
🎄 Happy Christmas! 🎅