Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data attributes to FacetItem component #694

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

julixC
Copy link

@julixC julixC commented Feb 20, 2025

What problem is this solving?

Add data attributes to be able to collect search information through activity flow

How to test it?

  1. Clone this styleguide project with the altered checkbox component and link it on VTEX IO to an account that uses the checkbox component.
    (I am using hering, testing the filter's checkbox)
  2. Clone this repository and link it on VTEX IO to the same account
  3. Make a search
  4. Right-click on top of the checkbox and select "Inspect"
  5. You should be able to see the information on data attributes like in the example below.
    image

@julixC julixC requested review from a team as code owners February 20, 2025 21:37
@julixC julixC requested review from gabpaladino, vsseixaso and leo-prange-vtex and removed request for a team February 20, 2025 21:37
Copy link
Contributor

vtex-io-ci-cd bot commented Feb 20, 2025

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Feb 20, 2025

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant