Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/faq #30

Merged
merged 18 commits into from
Feb 16, 2024
Merged

Feat/faq #30

merged 18 commits into from
Feb 16, 2024

Conversation

aliceoq
Copy link
Contributor

@aliceoq aliceoq commented Feb 7, 2024

What is the purpose of this pull request?

To add the FAQ pages.

What problem is this solving?

  • Added page that lists FAQs
  • Added page to show FAQ docs
  • Fixed position of the 'reading time' text in tracks and known issues.
  • Fixed filter/sort button height/padding
  • Fixed FAQ routes in sidebar, menu and hamburger menu

How should this be manually tested?

Open the preview and check if all the problems mentioned above are solved. Be sure to check the known issues and tracks pages, check all breakpoints and test the filter in the FAQ listing page.

Screenshots or example usage

image

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@aliceoq aliceoq added the release-minor Minor version bump label Feb 7, 2024
Copy link

netlify bot commented Feb 7, 2024

Deploy Preview for leafy-mooncake-7c2e5e ready!

Name Link
🔨 Latest commit 1b3cc74
🔍 Latest deploy log https://app.netlify.com/sites/leafy-mooncake-7c2e5e/deploys/65c63b32a987240008ca6efe
😎 Deploy Preview https://deploy-preview-30--leafy-mooncake-7c2e5e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aliceoq aliceoq requested a review from ThayllyR February 7, 2024 18:17
Copy link
Contributor

@ThayllyR ThayllyR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job ✨ LGTM

@aliceoq aliceoq marked this pull request as ready for review February 9, 2024 14:42
Copy link
Contributor

@Pvcunha Pvcunha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ThayllyR ThayllyR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

Copy link
Contributor

@RobsonOlv RobsonOlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 👏

@aliceoq aliceoq merged commit 910a960 into main Feb 16, 2024
5 checks passed
@aliceoq aliceoq deleted the feat/faq branch February 22, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-minor Minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants