Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix module symlinks #32

Merged
merged 6 commits into from
Nov 21, 2024
Merged

fix module symlinks #32

merged 6 commits into from
Nov 21, 2024

Conversation

smoors
Copy link
Member

@smoors smoors commented Nov 14, 2024 •
edited
Loading

AB#22973

UPDATE 2024-11-20:
reimplementation using moduleclasses, which should now solve all previous issues (but not yet fully tested)

@smoors smoors requested a review from lexming November 16, 2024 14:34
lexming
lexming approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a much cleaner approach than what we have been doing.

LGTM

@lexming lexming merged commit 64543e6 into vub-hpc:main Nov 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexming lexming lexming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smoors @lexming