Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devtools): setup the settings panel immediately #2858

Open
wants to merge 2 commits into
base: v3
Choose a base branch
from

Conversation

noootwo
Copy link
Contributor

@noootwo noootwo commented Dec 13, 2024

fix #2818

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for pinia-playground ready!

Name Link
🔨 Latest commit 89ac583
🔍 Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/675c1607b5b2ce0008a9f189
😎 Deploy Preview https://deploy-preview-2858--pinia-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for pinia-official ready!

Name Link
🔨 Latest commit 9084a99
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/67ac6c27e9b1cd000878e561
😎 Deploy Preview https://deploy-preview-2858--pinia-official.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Dec 13, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@pinia/nuxt@2858
npm i https://pkg.pr.new/pinia@2858
npm i https://pkg.pr.new/@pinia/testing@2858

commit: 9084a99

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.23%. Comparing base (e3b5f6d) to head (9084a99).

Additional details and impacted files
@@           Coverage Diff           @@
##               v3    #2858   +/-   ##
=======================================
  Coverage   91.23%   91.23%           
=======================================
  Files          17       17           
  Lines        1381     1381           
  Branches      211      211           
=======================================
  Hits         1260     1260           
  Misses        120      120           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@posva posva added the 🧑‍💻 pkg:devtools Related to devtools label Feb 12, 2025
@posva posva changed the base branch from v2 to v3 February 12, 2025 08:53
@posva
Copy link
Member

posva commented Feb 12, 2025

Is this still needed in the new version?

@noootwo
Copy link
Contributor Author

noootwo commented Feb 12, 2025

Is this still needed in the new version?

@posva Yes, the option about settings should be set when register pinia devtool.

@posva
Copy link
Member

posva commented Feb 12, 2025

I see. I think the fix should be different, registering the plugin once would be better. I will see later on if I can refactor the code for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 pkg:devtools Related to devtools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinia devtools will not call setupDevtoolsPlugin until useStore is called
2 participants