Skip to content

Add config oriented URL helper #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

Add config oriented URL helper #376

merged 1 commit into from
May 27, 2025

Conversation

terrorbyte
Copy link
Collaborator

This adds a little helper function so that we can stop doing:

url := protocol.GenerateURL(conf.Rhost, conf.Rport, conf.SSL, "/")

And instead have the shorter:

url := conf.GenerateURL("/")

This makes a little less clear sense vs being contained in protocol but does shorten the GenerateURL song and dance that is pervasive.

@terrorbyte terrorbyte requested a review from j-baines May 16, 2025 21:32
@terrorbyte terrorbyte self-assigned this May 16, 2025
@terrorbyte terrorbyte added the enhancement New feature or request label May 16, 2025
@j-baines j-baines merged commit e90bca5 into main May 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-baines j-baines j-baines approved these changes

Assignees

@terrorbyte terrorbyte

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terrorbyte @j-baines