This repository has been archived by the owner on Oct 29, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
Cleanup terms around "DID scheme" #185
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions: Change all references to "DID method scheme" to just "DID method". Using "scheme" in both places may confuse folks. While it is true that a "DID method" is a scheme, most readers will miss the nuance and most likely use "DID URI scheme" and "DID method scheme" interchangeably.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That works in some places, but I'm not sure about the section 'DID Method Schemes' (L1919) and generally how we differentiate between when the spec is talking about the method-specific character string in the DID, and the DID method itself. Or maybe we don't need to?
Eg. "A DID method specification MUST define exactly one DID method scheme identified by exactly one method name"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would replacing that with something like: "A DID method specification MUST define further restrictions to the
method
andspecific-idstring
parameters defined in the DID URI scheme"?The goal would be to effectively state: "There is one DID URI scheme, that's in this specification." The "DID URI scheme" may be further restricted by DID method specifications."
... or does that not address the text you're concerned about?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So while I think that generally works, I still think we need to define and use a term for what the previous spec called a "DID method scheme", i.e., the syntax (ABNF) defined by a DID method that restricts the generic DID scheme.
How about we just call it a "DID method syntax"?
Also, I want to be able to continue to use the term "generic DID syntax" for this portion of this spec so that we can mirror the same language from RFC 3986. Read these two paragraphs:
So I would really like to use the same language to talk about the relationship of DIDs and DID methods, i.e., to be able to say:
I'm drafting the proposed new text for the Decentralized Identifiers section of the spec (in this Google doc) to use this language. See what you think.