Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix firstInterimResponseStart name on diagram #200

Merged
merged 7 commits into from
Jul 29, 2024

Conversation

tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented May 1, 2024

firstInterimResponseStart went through some bikeshedding on the name in w3c/resource-timing#345. Looks like the diagram was updated with interimResponseStart without the first which is what landed.


Preview | Diff

@tunetheweb
Copy link
Member Author

Anyone any idea why CI is failing?

@yoavweiss
Copy link
Contributor

Seems like respec errors:

[FATAL] Error: Errors found during processing.
          at run (file:///home/runner/work/_actions/w3c/spec-prod/v2/node_modules/.pnpm/respec@35.0.2_typescript@5.4.4/node_modules/respec/tools/respec2html.js:258:11)
          at async file:///home/runner/work/_actions/w3c/spec-prod/v2/node_modules/.pnpm/respec@35.0.2_typescript@5.4.4/node_modules/respec/tools/respec2html.js:205:5
    Command `respec -s "http://localhost:3000/index.html?gitRevision=5c1fde5731b5125ff543556f502f5d14c59a3dc0" -o "index.html.built.html" --verbose -t 20 -e` failed with exit code: 1.
    ```

Might be unrelated to your change..

@@ -69,7 +69,6 @@
caniuse: "nav-timing",
mdn: "navigation-timing",
xref: {
url: "https://respec.org/xref",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seemed to break the build. Not sure why, and can't find any associated change in https://github.com/speced/respec/ but this line isn't in Resource Timing and doesn't seem to be needed.

@tunetheweb tunetheweb requested a review from noamr July 29, 2024 10:56
@tunetheweb tunetheweb merged commit f27ad34 into gh-pages Jul 29, 2024
2 checks passed
@noamr noamr deleted the firstInterimResponseStart branch July 29, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants