Handle FOs, not mere dissent, after a REC's AC Review #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frivoal
commented
Feb 12, 2025
TallTed
reviewed
Feb 12, 2025
frivoal
added
the
Closed: Accepted
|
The Process CG choose to use this rephrasing rather than dropping the paragraph, because it looks like dropping the paragraph would have some side effects, like removing the requirement to wait 14 days. It might be worth separately pursuing a refactoring that centralizes this 14 days requirement and lets us get rid of the paragraph, but until then, fixing it seemed more concervative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #978
The alternative would be to simply remove the paragraph, and rely on the generic text about AC reviews and FOs.