Proposal: Add tabGroups.tabGroup.shared #761
Open
+71
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add proposal.
Create tab_group_shared_state.md
oliverdunk
approved these changes
Feb 10, 2025
Co-authored-by: Oliver Dunk <oliver@oliverdunk.com>
Co-authored-by: Oliver Dunk <oliver@oliverdunk.com>
xeenon
approved these changes
Feb 18, 2025
| [chrome.tabGroups.tabGroup](https://developer.chrome.com/docs/extensions/reference/api/tabGroups#type-TabGroup)`.shared` | ||
| a boolean field which will denote whether the group is in a shared state or not. | ||
| [chrome.tabGroups.query](https://developer.chrome.com/docs/extensions/reference/api/tabGroups#method-query) | ||
| the `queryInfo` parameter will accept a new field`shared bool optional` |
There was a problem hiding this comment.
Suggested change
| the `queryInfo` parameter will accept a new field`shared bool optional` | |
| the `queryInfo` parameter will accept a new field `shared bool optional` |
| a method that is currently fired when a group is udated, will also fire when the group's shared state changes. | ||
| ### Behavior | ||
|
|
||
| Browsers may place browser-specific restrictions on shared groups for security and privacy purposes. This is not limited to the tabGroups API and could extend to chrome.tabs and other related API surfaces. The restriction would result in an error that "the action can not be performed due to the object being in a shared state." or a similar error message. |
There was a problem hiding this comment.
Suggested change
| Browsers may place browser-specific restrictions on shared groups for security and privacy purposes. This is not limited to the tabGroups API and could extend to chrome.tabs and other related API surfaces. The restriction would result in an error that "the action can not be performed due to the object being in a shared state." or a similar error message. | |
| Browsers may place browser-specific restrictions on shared groups for security and privacy purposes. This is not limited to the `tabGroups` API and could extend to `browser.tabs` and other related API surfaces. The restriction would result in an error that "the action can not be performed due to the object being in a shared state." or a similar error message. |
| [chrome.tabGroups.query](https://developer.chrome.com/docs/extensions/reference/api/tabGroups#method-query) | ||
| the `queryInfo` parameter will accept a new field`shared bool optional` | ||
| When provided the tab groups query will filter based on the shared states of the group. | ||
| [chrome.tabGroups.onUpdated](https://developer.chrome.com/docs/extensions/reference/api/tabGroups#event-onUpdated) |
There was a problem hiding this comment.
Suggested change
| [chrome.tabGroups.onUpdated](https://developer.chrome.com/docs/extensions/reference/api/tabGroups#event-onUpdated) | |
| [browser.tabGroups.onUpdated](https://developer.chrome.com/docs/extensions/reference/api/tabGroups#event-onUpdated) |
|
|
||
| ### Schema | ||
|
|
||
| [chrome.tabGroups.tabGroup](https://developer.chrome.com/docs/extensions/reference/api/tabGroups#type-TabGroup)`.shared` |
There was a problem hiding this comment.
Suggested change
| [chrome.tabGroups.tabGroup](https://developer.chrome.com/docs/extensions/reference/api/tabGroups#type-TabGroup)`.shared` | |
| [browser.tabGroups.tabGroup](https://developer.chrome.com/docs/extensions/reference/api/tabGroups#type-TabGroup)`.shared` |
|
|
||
| [chrome.tabGroups.tabGroup](https://developer.chrome.com/docs/extensions/reference/api/tabGroups#type-TabGroup)`.shared` | ||
| a boolean field which will denote whether the group is in a shared state or not. | ||
| [chrome.tabGroups.query](https://developer.chrome.com/docs/extensions/reference/api/tabGroups#method-query) |
There was a problem hiding this comment.
Suggested change
| [chrome.tabGroups.query](https://developer.chrome.com/docs/extensions/reference/api/tabGroups#method-query) | |
| [browser.tabGroups.query](https://developer.chrome.com/docs/extensions/reference/api/tabGroups#method-query) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposal introducing shared state. see issue #749