Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(weave): New trace view: design tweaks #3868

Draft
wants to merge 17 commits into
base: tim/fresh_trace_views
Choose a base branch
from

Conversation

m-rgba
Copy link
Contributor

@m-rgba m-rgba commented Mar 9, 2025

Based off of:
#3834

Description

WIP: DNM

Trace tree:

  • Conditionally hid parent/root call show and tell when disabled.
  • Updated search to show children and parents.
    • Added highlight to searched text in nodes.
  • Added line-work to help illustrate hierarchy.
  • Added tooltips to call names for truncated calls.
  • Moved call category icons to right side.
    • Updated icons to make them smaller
    • Colored based on category "types" (Identifiers, Completions/Tools, Evals, Other).
  • Added token count into token cost tooltip - consolidated into one column.
  • Added button to swap between token cost and latency.

Scrubbers:

  • Updated scrubber colors.
  • Add expand and collapse to show one or many scrubbers (pushes on and off page).

Tooltip (component):

  • Updated tooltip divider (general) to add padding that wasn't rendering.

Feedback tasks

  • Bug: Search w/ children - don't show siblings (that are linked to parent)
  • Search w/ children may show too much for some situations - add strict filtering to only show exact matches
  • Green category too close to success checkmark - use different color (also look at evals)
  • Bug: Show/hide logic on scrubbers (specifically code view being hidden)
  • Bug: Investigate pixel shifting scrubbers

@m-rgba m-rgba changed the title Trace view design tweaks feat(weave): New trace view: design tweaks Mar 9, 2025
@circle-job-mirror
Copy link

circle-job-mirror bot commented Mar 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant