-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/image build improvements #44
Open
bap14
wants to merge
131
commits into
wardenenv:main
Choose a base branch
from
bap14:feature/image-build-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@navarr Okay, i made a small adjustment to the main workflow and made the environment optional. I ran it twice (once without Dockerhub and once with) and both times the full process completed successfully. The run took 43 minutes to complete. ![]() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@navarr This restructures the PHP image build process. It builds arm64 on arm64 runners and amd64 on amd64 runners. It also parallelizes the different variations of images as much as possible (e.g. run 7.4, 8.x at the same time). It also adds a more dynamic PHP version loading, so when 8.5 drops we won't need to update the builder (unless we stop building 7.4).
In order to keep the "php" workflow from being 10,000 lines long, and because GitHub Actions don't support yaml anchors and merging, I split the workflows into individual yaml files when we were doing the same tasks over and over again.
Finally it adds a container structure testing tool which validates that the built docker image contains the things it should for that particular image (e.g. extensions, configurations, utilities, etc.).
I know it's a large pull request, but there was kind of no way around it. I didn't test this without an environment (with relation to secrets). I can run that test, but wanted to get this PR over to you.