Puppet 8 changes

[pearsondavid]

drop deprecated function validate_legacy

use variables for cert content

general format tidying

fix indexer_cluster_cn

re-opening, this was closed when master branch was re-named to main.

Any feedback would be welcome, rather than being ignored.

[vcerenu]

Hello @pearsondavid

Thanks for your contribution!

I see that the changes to the use of Puppet facts are good; we still need to test them, but the work done is greatly appreciated.

Regarding some changes, I have some questions and corrections:

• Regarding the use of variables for the certificate names in the function that handles the certificates created in Puppet Server, it's fine and offers more customization possibilities, but the name should contain the variable $indexer_node_name, which allows us to send the correct certificates to each of the Wazuh indexer nodes we want to install in one run (I'll leave a comment about each of the variables that need to be corrected).
• I see that the wazuh::manager class has been removed. Can you verify if this is correct and where the code for this class would be?

Also, please sign the commits you make.

I'll be reviewing the code as I test it. These changes will be included in the 5.0.0 release we're working on. As soon as we have the release branches ready, I'll ask you to commit these changes to that branch.

Thank you very much in advance, and I appreciate the work you've done again.