-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wikiman: support patchUrls for extensions #428
base: main
Are you sure you want to change the base?
Conversation
I think I made these comments somewhere in the past but perhaps not in text form. I don't have a strong objection to this patch but I don't feel like it resolves the root issue of forgetting to check the patchUrls when updating references. This now inverts the problem. We may keep patching accidentally when we shouldn't rather than the previous situation where we would forget to patch. Maybe what we instead need is a checklist for doing patch (or even smaller) updates. I could imagine something along the following lines:
|
This PR is a band-aid for sure and doesn't fix the design problems of the update process. Personally I think reviewing each extension patch, as well as each extension update, is unrealistic and there are no checls in place to enforce this. In contrast, it's incredibly easy for missing patchUrls to slip through code review, which would probably break our mediawiki deployments. A different approach could be to intermediately manually edit the pacman.yaml in such cases but I expect that just would make everything even more unpredictable. |
note: should be rebased after #439 gets merged |
Currently the
wikiman
does not respectpatchUrls
that we manually add to thepacman.yaml
(example). This can be quite dangerous as it is easy to miss re-adding them when using wikiman. I think we can circumvent this if we add them to thewikiman.yaml
already.