feat(platform): refer to platform status in error pages #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m90
commented
Jun 10, 2024
| @@ -7,13 +7,14 @@ | |||
| \WBStack\Info\GlobalSet::forDomain($_SERVER['SERVER_NAME']); | |||
| } catch (\WBStack\Info\GlobalSetException $ex) { | |||
| http_response_code($ex->getCode()); | |||
| echo "You have requested the domain: " . $_SERVER['SERVER_NAME'] . ". But that wiki can not currently be loaded.".PHP_EOL; | |||
| echo "You have requested the domain: " . $_SERVER['SERVER_NAME'] . ". But that wiki can not currently be loaded.<br/>"; | |||
There was a problem hiding this comment.
Replacing PHP_EOL with <br> is a drive by fix as I noticed this currently did not work as intended.
m90
commented
Jun 10, 2024
| } | ||
| echo $ex->getMessage(); | ||
| echo $ex->getMessage()."<br/>"; | ||
| echo "You can check the platform status at <a href=\"https://status.wikibase.cloud\">status.wikibase.cloud</a><br/>."; |
There was a problem hiding this comment.
This means we'll also display the link on 404 (expected) responses, but I guess that's ok?
dist/wbstack/src/Shim/Web.php
Outdated
There was a problem hiding this comment.
There's a few <br/>. which you might want to swap out with .<br/>.
AndrewKostka
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket https://phabricator.wikimedia.org/T365492