Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: local http switch logic #468

Merged
merged 3 commits into from
Jan 16, 2025
Merged

fix: local http switch logic #468

merged 3 commits into from
Jan 16, 2025

Conversation

deer-wmde
Copy link
Contributor

Since recently https is used locally in miniikube environments (but not in the docker-compose setup for CI), this adds a small adjustment to only switch to http in that case.

tarrow
tarrow reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@tarrow tarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and we keep $wwDomainSaysLocal for the exception details right?

@deer-wmde
Copy link
Contributor Author

and we keep $wwDomainSaysLocal for the exception details right?

yes since that should be true in both minikube and docker-compose scenarios if i understand the code correctly

@deer-wmde deer-wmde merged commit 958b472 into main Jan 16, 2025
9 checks passed
@deer-wmde deer-wmde deleted the de/local-https branch January 16, 2025 11:53
@deer-wmde deer-wmde mentioned this pull request Jan 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrow tarrow tarrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deer-wmde @tarrow