fix(dockerfile): intl php extension is not installed #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain scenarios the code in quickstatements tries to call the global `normalizer_normalize` function which is not available unless the `intl` extension is installed. Ticket: https://phabricator.wikimedia.org/T365916
AndrewKostka
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Phabricator
https://phabricator.wikimedia.org/T365916
Prior discussion
None
Describe the changes
Certain code paths in Quickstatements try to call
normalizer_normalize, which currently throws an unhandled exception as the global function is not available.The function is provided by the
intlextension, so this PR fixes the problem by installing the extension in the Docker image.The way of installing the extension is copied verbatim (plus version pins) from the wikibase-release-pipeline.
This is what I need help with
I tested this locally using the steps provided in the ticket, but as I am far from a Quickstatements expert, it'd be good if the reviewer can confirm that this works for them as well locally.