fix: contentlanguages need to be matched before piping output to target #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m90
commented
Jul 23, 2024
tarrow
reviewed
Jul 24, 2024
| @@ -1,8 +1,9 @@ | |||
| FROM node:20-alpine | |||
|
|
|||
| RUN apk add --no-cache jq=1.7.1-r0 curl=8.8.0-r0 && \ | |||
| RUN apk add --no-cache curl=8.8.0-r0 python3=3.12.3-r1 && \ | |||
There was a problem hiding this comment.
i'd not noticed this removed the jq dependency; that's a nice happy accident
m90
force-pushed
the
fr/match-content-languages
branch
2 times, most recently
from
6dc9fec to
b169f4a
Compare
m90
force-pushed
the
fr/match-content-languages
branch
from
b169f4a to
d1eac24
Compare
tarrow
approved these changes
Jul 24, 2024
| @@ -0,0 +1,152 @@ | |||
| #!/usr/bin/env python3 | |||
|
|
|||
| import unittest | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects maxlath/wikibase-cli#188
The script is a bit all over the place (i.e. it's doing two totally unrelated things at once), but I felt it's ok since the surface area is still very small and future readers might only be interested in the fact that data is "somehow mangled".