Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rubocop: Bulk Change Table rule is not useful #218

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Rubocop: Bulk Change Table rule is not useful #218

merged 4 commits into from
Jan 26, 2024

Conversation

bemisguided
Copy link
Contributor

Why

This rule is not really useful.

Combine this with the fact that this syntax then requires safety_assured to be used, it makes it counter productive.

What changed

Disable Rails/BulkChangeTable

@bemisguided bemisguided requested a review from a team as a code owner January 24, 2024 21:34
desheikh
desheikh approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@desheikh desheikh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to bump version.rb, run bundle and add a changelog.

@bemisguided bemisguided merged commit 6322e61 into main Jan 26, 2024
5 checks passed
@bemisguided bemisguided deleted the chore/remove-rails-bulk-change-table branch January 26, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desheikh desheikh desheikh approved these changes

@tylermarien tylermarien tylermarien approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bemisguided @desheikh @tylermarien