Ignite wrapper #481
Ignite wrapper #481
Conversation
There was a problem hiding this comment.
I'm concerned about the need to maintain this and distribute CNI in this manner.
User's machine may already have CNI installed which may cause some strange interactions.
I'm also willing to consider this as default behavior since the parent CNI project does not yet have mature packaging.
The k8s project has been distributing debs and rpm's themselves which they are planning to change.
More discussion in the recording from: https://docs.google.com/document/d/1fv8_WD6qXfvlIq7Bb5raCGyBvc42dNF-l8uaoZzoUYI/edit#heading=h.3x3r3cf1tpzj
| @@ -265,6 +265,12 @@ serve-docs: build-docs | |||
| @echo Stating docs website on http://localhost:${DOCS_PORT}/_build/html/index.html | |||
| @$(DOCKER) run -i --rm -p ${DOCS_PORT}:8000 -e USER_ID=$$UID ignite-docs | |||
|
|
|||
| build-ignitew: build-all | |||
There was a problem hiding this comment.
we can change this to ignite instead of build-all
| checks = append(checks, ExistingFileChecker{filePath: dependency}) | ||
| // In case of using ignitew, we put CNI plugin binaries relatively to the executable | ||
| exeDir := filepath.Dir(os.Args[0]) | ||
| if _, err := os.Stat(exeDir); err == nil { |
There was a problem hiding this comment.
I believe this may always be true -- it doesn't indicate that the binary is actually ignitew
Perhaps there's a warp native way to detect that the binaries have been unpacked for us
|
The Makefile needs to be updated to output We should make note whether this also supports ARM64 builds. |
|
A build shows that the resulting binary size of This is likely just the size of the CNI binaries themselves. It's unfortunate because I believe every one of those is an independent Go binary 😅 |
|
This is a pretty cool all-in-one solution, has it just dropped to the bottom of the backlog? |
This PR introduce
ignitew, a self-contained binary bundlingigniteand CNI plugin binaries together.ignitewcan be used as a drop-in replacement ofigniteOOTB without user manually installing CNI plugins.It uses the excellent
warp-packerhttps://github.com/dgiagio/warp to create the self contained binary. It uses no sandbox, so that the behaviour could be expected to be similar to the normalignite.Example: