This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
[POC] Import images from tar file #557
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements importing local container images from tar file. Uses a new subcommand `tarimport` for now, since `import` command is already used for pulling the image from image repository. Adds a new function ImportImage() in the runtime interface and implements them for docker and containerd runtimes. The images are first imported into the runtime's image store and then copied to ignite's backend store as ignite VM images. Usage: ignite image tarimport hello-world.tar
darkowlzz
commented
Mar 10, 2020
| @@ -29,6 +29,10 @@ func (ds *DockerSource) Ref() meta.OCIImageRef { | |||
| return ds.imageRef | |||
| } | |||
|
|
|||
| func (ds *DockerSource) SetRef(imageRef meta.OCIImageRef) { | |||
| ds.imageRef = imageRef | |||
| } | |||
There was a problem hiding this comment.
SetRef is required to use the correct imageRef in DockerSource.Reader when a single image tar file contains multiple images. DockerSource importing multiple images require this option to set the imageRef of the DockerSource when the images are read.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements importing local container images from tar file. Uses a new
subcommand
tarimportfor now, sinceimportcommand is already usedfor pulling the image from image repository.
Adds a new function
ImportImage()in the runtime interface andimplements them for docker and containerd runtimes. The images are first
imported into the runtime's image store and then copied to ignite's
backend store as ignite VM images.
Usage:
Tar files can be created using
docker save.tarimportis a placeholder subcommand for now. It'll be changed to something better after some feedback about the implementation.