Charles | updated empty string test

casibbald · casibbald · commit 032a90ffbe7e · 2024-11-13T10:20:22.000+02:00
diff --git a/pkg/sourceignore/sourceignore.go b/pkg/sourceignore/sourceignore.go
@@ -121,7 +121,7 @@ func ReadPatterns(reader io.Reader, domain []string) []gitignore.Pattern {
 	scanner := bufio.NewScanner(reader)
 	for scanner.Scan() {
 		s := scanner.Text()
-		if !strings.HasPrefix(s, "#") && len(strings.TrimSpace(s)) > 0 {
+		if !strings.HasPrefix(s, "#") && strings.TrimSpace(s) != "" {
 			ps = append(ps, gitignore.ParsePattern(s, domain))
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ func ReadPatterns(reader io.Reader, domain []string) []gitignore.Pattern {`
`121`	`121`	`scanner := bufio.NewScanner(reader)`
`122`	`122`	`for scanner.Scan() {`
`123`	`123`	`s := scanner.Text()`
`124`		`- if !strings.HasPrefix(s, "#") && len(strings.TrimSpace(s)) > 0 {`
	`124`	`+ if !strings.HasPrefix(s, "#") && strings.TrimSpace(s) != "" {`
`125`	`125`	`ps = append(ps, gitignore.ParsePattern(s, domain))`
`126`	`126`	`}`
`127`	`127`	`}`