Merge pull request #4456 from erikgb/eslint

Upgrade eslint and migrate config

Author: erikgb

.eslintrc

@@ -0,0 +1,52 @@
+import eslint from '@eslint/js';
+import tseslint from 'typescript-eslint';
+import importPlugin from 'eslint-plugin-import';
+
+export default tseslint.config([
+    {
+        ignores: [
+            "**/*.pb.ts",
+            "**/*.js",
+            "**/*.mjs"
+        ],
+    },
+    {
+        extends: [
+            eslint.configs.recommended,
+            importPlugin.flatConfigs.errors,
+            importPlugin.flatConfigs.warnings,
+            tseslint.configs.recommended,
+            importPlugin.flatConfigs.typescript,
+        ],
+        rules: {
+            "import/default": 0,
+            "import/no-named-as-default-member": 0,
+            "import/named": 2,
+            "import/order": [
+                2,
+                {
+                    alphabetize: {
+                        order: "asc",
+                        caseInsensitive: true,
+                    },
+                }
+            ],
+            "@typescript-eslint/explicit-module-boundary-types": 0,
+            "@typescript-eslint/no-explicit-any": 0,
+            "@typescript-eslint/ban-ts-comment": 0,
+            "import/no-named-as-default": 0,
+            "@typescript-eslint/switch-exhaustiveness-check": ["error",
+                {
+                    "considerDefaultExhaustiveForUnions": true
+                }],
+            "import/no-unresolved": 0,
+        },
+        languageOptions: {
+            ecmaVersion: 5,
+            sourceType: "script",
+            parserOptions: {
+                project: "./tsconfig.json",
+            },
+        },
+    }
+]);

eslint.config.mjs

@@ -84,6 +84,7 @@
   },
   "devDependencies": {
     "@babel/core": "^7.26.0",
+    "@eslint/js": "9.17.0",
     "@parcel/babel-preset-env": "^2.13.3",
     "@parcel/config-default": "^2.8.3",
     "@parcel/core": "^2.13.3",
@@ -100,12 +101,10 @@
     "@types/react": "^18.0.0",
     "@types/react-dom": "^18.0.0",
     "@types/react-is": "^18",
-    "@typescript-eslint/eslint-plugin": "^6.6.0",
-    "@typescript-eslint/parser": "^6.6.0",
     "babel-jest": "^29.7.0",
     "babel-plugin-styled-components": "^2.1.4",
     "buffer": "^6.0.3",
-    "eslint": "8.57.1",
+    "eslint": "9.17.0",
     "eslint-plugin-import": "^2.31.0",
     "jest": "^29.7.0",
     "jest-environment-jsdom": "^29.7.0",
@@ -119,6 +118,7 @@
     "react-test-renderer": "^18.0.0",
     "ts-jest": "^29.2.5",
     "typescript": "^5.2.2",
+    "typescript-eslint": "^8.19.1",
     "yarn-audit-fix": "^10.1.1"
   },
   "alias": {

package.json

@@ -21,14 +21,12 @@ type Props = {
   loading: boolean;
 };
 
-const defaultInitialState = () => ({
-  name: "",
-  namespace: "",
-  source: "",
-  path: "",
-});
-
-type FormState = ReturnType<typeof defaultInitialState>;
+type FormState = {
+  name: "";
+  namespace: "";
+  source: "";
+  path: "";
+};
 
 function AddKustomizationForm({
   className,

ui/components/AddKustomizationForm.tsx

@@ -1,4 +1,3 @@
-// eslint-disable-next-line
 import { CircularProgress } from "@mui/material";
 import MaterialButton, { type ButtonProps } from "@mui/material/Button";
 import * as React from "react";

ui/components/Button.tsx

@@ -37,7 +37,6 @@ import WarningIcon from "@mui/icons-material/Warning";
 import * as React from "react";
 import styled from "styled-components";
 import images from "../lib/images";
-// eslint-disable-next-line
 import { colors, fontSizes, spacing } from "../typedefs/styled";
 import Flex from "./Flex";
 import ApplicationsIcon from "./NavIcons/ApplicationsIcon";

ui/components/Icon.tsx

@@ -6,7 +6,6 @@ import styled from "styled-components";
 import { formatURL } from "../lib/nav";
 import { PageRoute, V2Routes } from "../lib/types";
 import { Fade } from "../lib/utils";
-// eslint-disable-next-line
 import { colors } from "../typedefs/styled";
 
 import Flex from "./Flex";

ui/components/Nav.tsx

@@ -14,6 +14,8 @@ import Spacer from "./Spacer";
 // https://github.com/parcel-bundler/parcel/issues/8792
 // https://github.com/weaveworks/weave-gitops/issues/3672
 // Theory: this is tricking parcel into correctly importing d3. :shrug:
+// TODO: Investigate if this can be removed safely via a component upgrade path
+// eslint-disable-next-line @typescript-eslint/no-unused-expressions
 d3;
 
 interface Props {

ui/components/ReconciliationGraph.tsx

@@ -1,5 +1,4 @@
 import styled from "styled-components";
-// eslint-disable-next-line
 import { spacing } from "../typedefs/styled";
 
 type Spacing = keyof typeof spacing;

ui/components/Spacer.tsx

@@ -1,5 +1,4 @@
 import styled from "styled-components";
-// eslint-disable-next-line
 import { colors, fontSizes } from "../typedefs/styled";
 
 export interface TextProps {

ui/components/Text.tsx

@@ -1,6 +1,5 @@
 import { createGlobalStyle } from "styled-components";
 // Typescript will handle type-checking/linting for this file
-/* eslint-disable */
 // @ts-ignore
 import ProximaNovaBold from "url:../fonts/ProximaNovaBold.otf";
 // @ts-ignore

ui/lib/fonts.ts

@@ -262,7 +262,7 @@ export class HelmRelease extends FluxObject {
     super(response);
     try {
       this.inventory = response.inventory || [];
-    } catch (error) {
+    } catch {
       this.inventory = [];
     }
   }