Fix eslint errors after upgrade

Author: erikgb

eslint.config.mjs

@@ -2,40 +2,51 @@ import eslint from '@eslint/js';
 import tseslint from 'typescript-eslint';
 import importPlugin from 'eslint-plugin-import';
 
-export default tseslint.config({
-    extends: [
-        eslint.configs.recommended,
-        importPlugin.flatConfigs.errors,
-        importPlugin.flatConfigs.warnings,
-        tseslint.configs.recommended,
-        importPlugin.flatConfigs.typescript,
-    ],
-    rules: {
-        "import/default": 0,
-        "import/no-named-as-default-member": 0,
-        "import/named": 2,
-        "import/order": [
-            2,
-            {
-                alphabetize: {
-                    order: "asc",
-                    caseInsensitive: true,
-                },
-            }
+export default tseslint.config([
+    {
+        ignores: [
+            "**/*.pb.ts",
+            "**/*.js",
+            "**/*.mjs"
         ],
-        "@typescript-eslint/explicit-module-boundary-types": 0,
-        "@typescript-eslint/no-explicit-any": 0,
-        "@typescript-eslint/ban-ts-comment": 0,
-        "import/no-named-as-default": 0,
-        "@typescript-eslint/switch-exhaustiveness-check": "error",
-        "import/no-unresolved": 0,
     },
-    ignores: ["**/*.pb.ts"],
-    languageOptions: {
-        ecmaVersion: 5,
-        sourceType: "script",
-        parserOptions: {
-            project: "./tsconfig.json",
+    {
+        extends: [
+            eslint.configs.recommended,
+            importPlugin.flatConfigs.errors,
+            importPlugin.flatConfigs.warnings,
+            tseslint.configs.recommended,
+            importPlugin.flatConfigs.typescript,
+        ],
+        rules: {
+            "import/default": 0,
+            "import/no-named-as-default-member": 0,
+            "import/named": 2,
+            "import/order": [
+                2,
+                {
+                    alphabetize: {
+                        order: "asc",
+                        caseInsensitive: true,
+                    },
+                }
+            ],
+            "@typescript-eslint/explicit-module-boundary-types": 0,
+            "@typescript-eslint/no-explicit-any": 0,
+            "@typescript-eslint/ban-ts-comment": 0,
+            "import/no-named-as-default": 0,
+            "@typescript-eslint/switch-exhaustiveness-check": ["error",
+                {
+                    "considerDefaultExhaustiveForUnions": true
+                }],
+            "import/no-unresolved": 0,
         },
-    },
-});
+        languageOptions: {
+            ecmaVersion: 5,
+            sourceType: "script",
+            parserOptions: {
+                project: "./tsconfig.json",
+            },
+        },
+    }
+]);

ui/components/AddKustomizationForm.tsx

@@ -21,14 +21,12 @@ type Props = {
   loading: boolean;
 };
 
-const defaultInitialState = () => ({
-  name: "",
-  namespace: "",
-  source: "",
-  path: "",
-});
-
-type FormState = ReturnType<typeof defaultInitialState>;
+type FormState = {
+  name: "";
+  namespace: "";
+  source: "";
+  path: "";
+};
 
 function AddKustomizationForm({
   className,

ui/components/ReconciliationGraph.tsx

@@ -14,6 +14,8 @@ import Spacer from "./Spacer";
 // https://github.com/parcel-bundler/parcel/issues/8792
 // https://github.com/weaveworks/weave-gitops/issues/3672
 // Theory: this is tricking parcel into correctly importing d3. :shrug:
+// TODO: Investigate if this can be removed safely via a component upgrade path
+// eslint-disable-next-line @typescript-eslint/no-unused-expressions
 d3;
 
 interface Props {

ui/lib/objects.ts

@@ -262,7 +262,7 @@ export class HelmRelease extends FluxObject {
     super(response);
     try {
       this.inventory = response.inventory || [];
-    } catch (error) {
+    } catch {
       this.inventory = [];
     }
   }