You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
<!--
Use # to add the issue this pull request is related to.
nb: This is the Github issue number, not a Zenhub link.
Do not use any punctuation or bullet points.
eg:
Closes#1234
Fixes #5678
-->
Closes
<!-- Describe what has changed in this PR -->
**What changed?**
initializing logger earlier on in start process
<!-- Tell your future self why have you made these changes -->
**Why was this change made?**
`
[controller-runtime] log.SetLogger(...) was never called; logs will not
be displayed.
Detected at:
> goroutine 434 [running]:
> runtime/debug.Stack()
> /usr/local/go/src/runtime/debug/stack.go:26 +0x64
> sigs.k8s.io/controller-runtime/pkg/log.eventuallyFulfillRoot()
> /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.19.4/pkg/log/log.go:60
+0xa0
>
sigs.k8s.io/controller-runtime/pkg/log.(*delegatingLogSink).WithName(0x4000132580,
{0x3291787, 0x14})
>
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.19.4/pkg/log/deleg.go:147
+0x34
> github.com/go-logr/logr.Logger.WithName({{0x3600dc8, 0x4000132580},
0x0}, {0x3291787, 0x14})
> /go/pkg/mod/github.com/go-logr/logr@v1.4.2/logr.go:345 +0x5c
> sigs.k8s.io/controller-runtime/pkg/client.newClient(0x400036d448,
{0x0, 0x4000261650, {0x3602610, 0x40006ad270}, 0x0, 0x0})
>
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.19.4/pkg/client/client.go:118
+0xf8
> sigs.k8s.io/controller-runtime/pkg/client.New(0x400029fd48, {0x0,
0x4000261650, {0x3602610, 0x40006ad270}, 0x0, 0x0})
>
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.19.4/pkg/client/client.go:98
+0x68
>
github.com/weaveworks/weave-gitops/core/clustersmngr/cluster.getClientFromConfig(0x400029fd48,
0x4000261650)
> /app/core/clustersmngr/cluster/single.go:69 +0x2f0
>
github.com/weaveworks/weave-gitops/core/clustersmngr/cluster.(*singleCluster).GetUserClient(0x40001320c0,
0x40007cfda0)
> /app/core/clustersmngr/cluster/single.go:94 +0x108
>
github.com/weaveworks/weave-gitops/core/clustersmngr.(*clustersManager).getOrCreateClient(0x40001acb40,
0x40007cfda0, {0x36023d0, 0x40001320c0})
> /app/core/clustersmngr/factory.go:623 +0x38c
>
github.com/weaveworks/weave-gitops/core/clustersmngr.(*clustersManager).getUserClientWithNamespaces.func1({0x36023d0,
0x40001320c0}, {0x35e7d98, 0x4000c9a890}, 0x4000974e00)
> /app/core/clustersmngr/factory.go:426 +0xd8
> created by
github.com/weaveworks/weave-gitops/core/clustersmngr.(*clustersManager).getUserClientWithNamespaces
in goroutine 402
> /app/core/clustersmngr/factory.go:423 +0x364
`
<!--
Explain to your reviewers the key implementation points, including why
you made
certain choices in favour of others. Highlight key areas of the code
which need
extra attention, and also indicate which parts are less relevant (eg
renaming,
refactoring, etc
-->
**How was this change implemented?**
<!--
How have you verified this change/product value? Tested locally?
Added integration/acceptance test(s)?
Unit tests are required.
-->
**How did you validate the change?**
Services starts, stacktrace gone
<!--
Is it notable for release? e.g. schema updates, configuration or data
migration
required? If so, please mention it.
-->
**Release notes**
<!-- Are there any documentation updates that should be made for these
changes? -->
**Documentation Changes**
0 commit comments