Skip to content

Commit db0078e

Browse files
authored
Merge branch 'main' into dependabot/npm_and_yarn/d3-dag-1.1.0
2 parents c10df1d + 9930bf1 commit db0078e

File tree

6 files changed

+65
-30
lines changed

6 files changed

+65
-30
lines changed

.github/workflows/pr.yaml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@ jobs:
7272
build-push-image:
7373
name: CI Build Image
7474
runs-on: ubuntu-latest
75+
env:
76+
IMAGE_NAME: ghcr.io/${{ github.repository }}/${{ matrix.docker-image }}
7577
permissions:
7678
packages: write # for docker/build-push-action to push images
7779
id-token: write # for Cosign to be able to sign images with GHA token
@@ -89,7 +91,7 @@ jobs:
8991
- uses: docker/metadata-action@369eb591f429131d6889c46b94e711f089e6ca96 # v5.6.1
9092
id: meta
9193
with:
92-
images: ghcr.io/${{ github.repository }}/${{ matrix.docker-image }}
94+
images: ${{ env.IMAGE_NAME }}
9395
tags: |
9496
type=ref,event=branch
9597
type=ref,event=pr
@@ -119,13 +121,14 @@ jobs:
119121
- name: Keyless signing of image
120122
if: ${{ github.event_name != 'pull_request' && github.repository == 'weaveworks/weave-gitops' }}
121123
run: |
124+
echo ${{ steps.build.outputs.imageid }}
122125
echo ${{ steps.build.outputs.digest }}
123-
cosign sign --yes ${{ steps.build.outputs.digest }}
126+
cosign sign --yes ${{ env.IMAGE_NAME }}@${{ steps.build.outputs.digest }}
124127
- name: Verify the image signing
125128
if: ${{ github.event_name != 'pull_request' && github.repository == 'weaveworks/weave-gitops' }}
126129
run: |
127-
cosign verify ${{ steps.build.outputs.digest }}
128-
--certificate-identity "https://github.com/${{ github.workflow_ref }}"
130+
cosign verify ${{ env.IMAGE_NAME }}@${{ steps.build.outputs.digest }} \
131+
--certificate-identity "https://github.com/${{ github.workflow_ref }}" \
129132
--certificate-oidc-issuer "https://token.actions.githubusercontent.com" | jq .
130133
131134
ci-upload-binary:

eslint.config.mjs

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,31 +19,27 @@ export default tseslint.config([
1919
importPlugin.flatConfigs.typescript,
2020
],
2121
rules: {
22-
"import/default": 0,
23-
"import/no-named-as-default-member": 0,
2422
"import/named": 2,
25-
"import/order": [
26-
2,
23+
"import/order": [2,
2724
{
2825
alphabetize: {
2926
order: "asc",
3027
caseInsensitive: true,
3128
},
3229
}
3330
],
34-
"@typescript-eslint/explicit-module-boundary-types": 0,
3531
"@typescript-eslint/no-explicit-any": 0,
3632
"@typescript-eslint/ban-ts-comment": 0,
3733
"import/no-named-as-default": 0,
38-
"@typescript-eslint/switch-exhaustiveness-check": ["error",
34+
"@typescript-eslint/switch-exhaustiveness-check": [2,
3935
{
4036
"considerDefaultExhaustiveForUnions": true
4137
}],
4238
"import/no-unresolved": 0,
4339
},
4440
languageOptions: {
45-
ecmaVersion: 5,
46-
sourceType: "script",
41+
ecmaVersion: 2018,
42+
sourceType: "commonjs",
4743
parserOptions: {
4844
project: "./tsconfig.json",
4945
},

jest.config.js

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,23 @@
1+
const transformIgnorePatterns = [
2+
'@emotion\/.*',
3+
'@mui\/.*',
4+
'd3',
5+
'd3-dag',
6+
'history',
7+
'http-proxy-middleware',
8+
'install',
9+
'jest-canvas-mock',
10+
'js-sha3',
11+
'lodash',
12+
'luxon',
13+
'mnemonic-browser',
14+
'postcss',
15+
'react',
16+
'react-.*',
17+
'remark-gfm',
18+
'styled-components',
19+
].join('|');
20+
121
/** @type {import('jest').Config} */
222
const config = {
323
preset: "ts-jest",
@@ -15,7 +35,7 @@ const config = {
1535
},
1636
],
1737
},
18-
transformIgnorePatterns: ["/node_modules/(?!(yaml|@asamuzakjp\/css-color))"],
38+
transformIgnorePatterns: [`/node_modules/(?:${transformIgnorePatterns})/`],
1939
setupFilesAfterEnv: ["<rootDir>/setup-jest.ts"],
2040
modulePathIgnorePatterns: ["<rootDir>/dist/"],
2141
testEnvironment: "jsdom",

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
"luxon": "^3.5.0",
6969
"mnemonic-browser": "^0.0.1",
7070
"postcss": "^8.4.49",
71-
"query-string": "^4.3.4",
71+
"query-string": "^9.1.1",
7272
"react": "^18.0.0",
7373
"react-dom": "^18.0.0",
7474
"react-is": "^18.0.0",

ui/pages/SignIn.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,8 @@ function SignIn({ darkModeEnabled = true }: Props) {
9393
const [showPassword, setShowPassword] = React.useState<boolean>(false);
9494

9595
const handleOIDCSubmit = () => {
96-
const redirect = qs.parse(window.location.search).redirect || "";
96+
const redirect =
97+
(qs.parse(window.location.search).redirect as string) || "";
9798

9899
// Head to the BE to start the OIDC flow so we do not use any of
99100
// react-router or other client-side routing

yarn.lock

Lines changed: 30 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -4387,7 +4387,7 @@ __metadata:
43874387
postcss: "npm:^8.4.49"
43884388
prettier: "npm:^3.4.2"
43894389
process: "npm:^0.11.10"
4390-
query-string: "npm:^4.3.4"
4390+
query-string: "npm:^9.1.1"
43914391
react: "npm:^18.0.0"
43924392
react-dom: "npm:^18.0.0"
43934393
react-is: "npm:^18.0.0"
@@ -6005,6 +6005,13 @@ __metadata:
60056005
languageName: node
60066006
linkType: hard
60076007

6008+
"decode-uri-component@npm:^0.4.1":
6009+
version: 0.4.1
6010+
resolution: "decode-uri-component@npm:0.4.1"
6011+
checksum: 10c0/a180bbdb5398ec8270d236a3ac07cb988bbf6097428481780b85840f088951dc0318a8d8f9d56796e1a322b55b29859cea29982f22f9b03af0bc60974c54e591
6012+
languageName: node
6013+
linkType: hard
6014+
60086015
"dedent@npm:^1.0.0":
60096016
version: 1.5.3
60106017
resolution: "dedent@npm:1.5.3"
@@ -6888,6 +6895,13 @@ __metadata:
68886895
languageName: node
68896896
linkType: hard
68906897

6898+
"filter-obj@npm:^5.1.0":
6899+
version: 5.1.0
6900+
resolution: "filter-obj@npm:5.1.0"
6901+
checksum: 10c0/716e8ad2bc352e206556b3e5695b3cdff8aab80c53ea4b00c96315bbf467b987df3640575100aef8b84e812cf5ea4251db4cd672bbe33b1e78afea88400c67dd
6902+
languageName: node
6903+
linkType: hard
6904+
68916905
"find-root@npm:^1.1.0":
68926906
version: 1.1.0
68936907
resolution: "find-root@npm:1.1.0"
@@ -10254,7 +10268,7 @@ __metadata:
1025410268
languageName: node
1025510269
linkType: hard
1025610270

10257-
"object-assign@npm:^4.1.0, object-assign@npm:^4.1.1":
10271+
"object-assign@npm:^4.1.1":
1025810272
version: 4.1.1
1025910273
resolution: "object-assign@npm:4.1.1"
1026010274
checksum: 10c0/1f4df9945120325d041ccf7b86f31e8bcc14e73d29171e37a7903050e96b81323784ec59f93f102ec635bcf6fa8034ba3ea0a8c7e69fa202b87ae3b6cec5a414
@@ -10840,13 +10854,14 @@ __metadata:
1084010854
languageName: node
1084110855
linkType: hard
1084210856

10843-
"query-string@npm:^4.3.4":
10844-
version: 4.3.4
10845-
resolution: "query-string@npm:4.3.4"
10857+
"query-string@npm:^9.1.1":
10858+
version: 9.1.1
10859+
resolution: "query-string@npm:9.1.1"
1084610860
dependencies:
10847-
object-assign: "npm:^4.1.0"
10848-
strict-uri-encode: "npm:^1.0.0"
10849-
checksum: 10c0/6181c343074c2049fbbcde63f87c1da5d3a49c6e34c8d94a61d692e886e0b8cd1ae4a4be00b598112bb9c4cb819e423ed503a5d246e4d24ecb0990d8bb21570b
10861+
decode-uri-component: "npm:^0.4.1"
10862+
filter-obj: "npm:^5.1.0"
10863+
split-on-first: "npm:^3.0.0"
10864+
checksum: 10c0/16481f17754f660aec3cae7abb838a70e383dfcf152414d184e0d0f81fae426acf112b4d51bf754f9c256eaf83ba4241241ba907c8d58b6ed9704425e1712e8c
1085010865
languageName: node
1085110866
linkType: hard
1085210867

@@ -11755,6 +11770,13 @@ __metadata:
1175511770
languageName: node
1175611771
linkType: hard
1175711772

11773+
"split-on-first@npm:^3.0.0":
11774+
version: 3.0.0
11775+
resolution: "split-on-first@npm:3.0.0"
11776+
checksum: 10c0/a1262eae12b68de235e1a08e011bf5b42c42621985ddf807e6221fb1e2b3304824913ae7019f18436b96b8fab8aef5f1ad80dedd2385317fdc51b521c3882cd0
11777+
languageName: node
11778+
linkType: hard
11779+
1175811780
"sprintf-js@npm:^1.1.3":
1175911781
version: 1.1.3
1176011782
resolution: "sprintf-js@npm:1.1.3"
@@ -11794,13 +11816,6 @@ __metadata:
1179411816
languageName: node
1179511817
linkType: hard
1179611818

11797-
"strict-uri-encode@npm:^1.0.0":
11798-
version: 1.1.0
11799-
resolution: "strict-uri-encode@npm:1.1.0"
11800-
checksum: 10c0/eb8a4109ba2588239787389313ba58ec49e043d4c64a1d44716defe5821a68ae49abe0cdefed9946ca9fc2a4af7ecf321da92422b0a67258ec0a3638b053ae62
11801-
languageName: node
11802-
linkType: hard
11803-
1180411819
"string-length@npm:^4.0.1":
1180511820
version: 4.0.2
1180611821
resolution: "string-length@npm:4.0.2"

0 commit comments

Comments
 (0)