refactor: migrate calls to deprecated grpc.Dial (#4376)

erikgb · web-flow · commit ea33d9fc2d3d · 2025-01-03T08:53:25.000+02:00
diff --git a/core/server/suite_test.go b/core/server/suite_test.go
@@ -109,9 +109,8 @@ func makeGRPCServer(ctx context.Context, cfg *rest.Config, t *testing.T) pb.Core
 		}
 	}(t)
 
-	//nolint:staticcheck // Ignore SA1019 deprecation warning for grpc.Dial
-	conn, err := grpc.Dial(
-		"bufnet",
+	conn, err := grpc.NewClient(
+		"passthrough://bufnet",
 		grpc.WithContextDialer(dialer),
 		grpc.WithTransportCredentials(insecure.NewCredentials()),
 	)
@@ -237,9 +236,8 @@ func dialBufnet(t *testing.T, lis *bufconn.Listener) *grpc.ClientConn {
 		return lis.Dial()
 	}
 
-	//nolint:staticcheck // Ignore SA1019 deprecation warning for grpc.Dial
-	conn, err := grpc.Dial(
-		"bufnet", // The address is ignored when using WithContextDialer
+	conn, err := grpc.NewClient(
+		"passthrough://bufnet",
 		grpc.WithContextDialer(dialer),
 		grpc.WithTransportCredentials(insecure.NewCredentials()), // Insecure for testing
 	)

Original file line number	Diff line number	Diff line change
`@@ -109,9 +109,8 @@ func makeGRPCServer(ctx context.Context, cfg rest.Config, t testing.T) pb.Core`
`109`	`109`	`}`
`110`	`110`	`}(t)`
`111`	`111`
`112`		`- //nolint:staticcheck // Ignore SA1019 deprecation warning for grpc.Dial`
`113`		`- conn, err := grpc.Dial(`
`114`		`- "bufnet",`
	`112`	`+ conn, err := grpc.NewClient(`
	`113`	`+ "passthrough://bufnet",`
`115`	`114`	`grpc.WithContextDialer(dialer),`
`116`	`115`	`grpc.WithTransportCredentials(insecure.NewCredentials()),`
`117`	`116`	`)`
`@@ -237,9 +236,8 @@ func dialBufnet(t testing.T, lis bufconn.Listener) *grpc.ClientConn {`
`237`	`236`	`return lis.Dial()`
`238`	`237`	`}`
`239`	`238`
`240`		`- //nolint:staticcheck // Ignore SA1019 deprecation warning for grpc.Dial`
`241`		`- conn, err := grpc.Dial(`
`242`		`- "bufnet", // The address is ignored when using WithContextDialer`
	`239`	`+ conn, err := grpc.NewClient(`
	`240`	`+ "passthrough://bufnet",`
`243`	`241`	`grpc.WithContextDialer(dialer),`
`244`	`242`	`grpc.WithTransportCredentials(insecure.NewCredentials()), // Insecure for testing`
`245`	`243`	`)`