chore: enable errchkjson linter (#4329)

Author: erikgb

.golangci.yaml

@@ -8,7 +8,7 @@ linters:
     #- contextcheck
     - depguard
     - errcheck
-    #- errchkjson
+    - errchkjson
     #- errname
     #- gochecknoinits
     - gci

cmd/gitops/get/config/cmd.go

@@ -41,12 +41,7 @@ func getConfigCommandRunE(opts *cfg.Options) func(*cobra.Command, []string) erro
 
 		log.Successf("Your CLI configuration for Weave GitOps:")
 
-		cfgStr, err := gitopsConfig.String()
-		if err != nil {
-			log.Failuref("Error printing config")
-			return err
-		}
-
+		cfgStr := gitopsConfig.String()
 		fmt.Println(cfgStr)
 
 		return nil

pkg/config/config.go

@@ -31,13 +31,9 @@ type GitopsCLIConfig struct {
 	UserID    string `json:"userId"`
 }
 
-func (config *GitopsCLIConfig) String() (string, error) {
-	data, err := json.MarshalIndent(&config, "", "  ")
-	if err != nil {
-		return "", fmt.Errorf("error encoding config: %w", err)
-	}
-
-	return string(data), nil
+func (config *GitopsCLIConfig) String() string {
+	data, _ := json.MarshalIndent(&config, "", "  ")
+	return string(data)
 }
 
 // SetConfig sets global config to the provided value
@@ -94,10 +90,7 @@ func SaveConfig(config *GitopsCLIConfig) error {
 		return err
 	}
 
-	data, err := json.MarshalIndent(&config, "", "  ")
-	if err != nil {
-		return fmt.Errorf("error encoding config: %w", err)
-	}
+	data, _ := json.MarshalIndent(&config, "", "  ")
 
 	configFile, err := openConfigFile(configPath, true)
 	if err != nil {

pkg/logger/s3_log_writer.go

@@ -67,10 +67,7 @@ func (l *S3LogWriter) putLog(msg string) {
 		Message:    msg,
 	}
 
-	logData, err := json.Marshal(result)
-	if err != nil {
-		l.log0.Failuref("failed to marshal log data to JSON: %v", err)
-	}
+	logData, _ := json.Marshal(result)
 
 	// append new line at the end of each log
 	logMsg := string(logData) + "\n"

pkg/server/auth/server.go

@@ -556,13 +556,9 @@ func (s *AuthServer) Refresh(rw http.ResponseWriter, r *http.Request) (*UserPrin
 }
 
 func toJSON(rw http.ResponseWriter, ui UserInfo, log logr.Logger) {
-	b, err := json.Marshal(ui)
-	if err != nil {
-		JSONError(log, rw, fmt.Sprintf("failed to marshal to JSON: %v", err), http.StatusInternalServerError)
-		return
-	}
+	b, _ := json.Marshal(ui)
 
-	_, err = rw.Write(b)
+	_, err := rw.Write(b)
 	if err != nil {
 		log.Error(err, "Failing to write response")
 	}
@@ -581,14 +577,10 @@ func (s *AuthServer) startAuthFlow(rw http.ResponseWriter, r *http.Request) {
 		returnURL = r.URL.String()
 	}
 
-	b, err := json.Marshal(SessionState{
+	b, _ := json.Marshal(SessionState{
 		Nonce:     nonce,
 		ReturnURL: returnURL,
 	})
-	if err != nil {
-		JSONError(s.Log, rw, fmt.Sprintf("failed to marshal state to JSON: %v", err), http.StatusInternalServerError)
-		return
-	}
 
 	state := base64.StdEncoding.EncodeToString(b)
 

pkg/server/auth/server_test.go

@@ -233,8 +233,7 @@ func TestSignInNoSecret(t *testing.T) {
 
 	s, _ := makeAuthServer(t, ctrlclientfake.NewClientBuilder().Build(), tokenSignerVerifier, []auth.AuthMethod{auth.OIDC}, &fakeSessionManager{})
 
-	j, err := json.Marshal(auth.LoginRequest{})
-	g.Expect(err).NotTo(HaveOccurred())
+	j, _ := json.Marshal(auth.LoginRequest{})
 
 	reader := bytes.NewReader(j)
 
@@ -277,8 +276,7 @@ func TestSignInWrongUsernameReturnsUnauthorized(t *testing.T) {
 		Password: "my-secret-password",
 	}
 
-	j, err := json.Marshal(login)
-	g.Expect(err).NotTo(HaveOccurred())
+	j, _ := json.Marshal(login)
 
 	reader := bytes.NewReader(j)
 
@@ -318,8 +316,7 @@ func TestSignInWrongPasswordReturnsUnauthorized(t *testing.T) {
 		Password: "wrong",
 	}
 
-	j, err := json.Marshal(login)
-	g.Expect(err).NotTo(HaveOccurred())
+	j, _ := json.Marshal(login)
 
 	reader := bytes.NewReader(j)
 
@@ -358,8 +355,7 @@ func TestSignInCorrectPassword(t *testing.T) {
 		Password: password,
 	}
 
-	j, err := json.Marshal(login)
-	g.Expect(err).NotTo(HaveOccurred())
+	j, _ := json.Marshal(login)
 
 	reader := bytes.NewReader(j)