Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable chrome overlay scrollbar animations #50298

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

flackr
Copy link
Contributor

@flackr flackr commented Jan 27, 2025

Overlay scrollbar animations are time delayed and not web visible or testable. Disable timed animation delays to ensure ref tests do not fail based on how long it takes to capture the screenshot. In particular, this flag ensures that the overlay scrollbar remains visible indefinitely after a scroll allowing the scrollbar position / appearance to be reliably tested even when overlay scrollbars are in use.

@flackr flackr requested a review from jgraham January 27, 2025 16:44
@wpt-pr-bot wpt-pr-bot added infra wptrunner The automated test runner, commonly called through ./wpt run labels Jan 27, 2025
@flackr flackr removed the request for review from jgraham January 27, 2025 16:51
@foolip
Copy link
Member

foolip commented Feb 10, 2025

@flackr have you done a full run with this flag to ensure that it only makes additional tests pass and doesn't regress any tests?

@flackr
Copy link
Contributor Author

flackr commented Feb 12, 2025

@foolip Thanks, I merged with 1a5b135 which had a wpt run for chrome canary and chrome stable and triggered a run. I think all the tests passed except for some infrastructure test which I'm not quite sure I understand, maybe I was supposed to rebase my change on top of the target commit instead or merging?

Overlay scrollbar animations are time delayed and not web
visible or testable. Disable timed animation delays to ensure
ref tests do not fail based on how long it takes to capture the
screenshot.
@flackr flackr force-pushed the disable-overlay-scrollbar-anims branch from 5d428e8 to a7ec527 Compare February 12, 2025 20:00
@foolip
Copy link
Member

foolip commented Feb 13, 2025

@flackr do you have a link to the results on wpt.fyi?

maybe I was supposed to rebase my change on top of the target commit instead or merging?

The commit history doesn't matter, as long as the diff between the commit and the one you're comparing to contains only the intended changes, then you got it right.

@foolip
Copy link
Member

foolip commented Feb 13, 2025

@flackr I see you rebased and triggered runs on a7ec527. Here's a view of the differences between the master branch and your changes:
https://wpt.fyi/results/?q=is%3Adifferent&run_id=5089997478952960&run_id=5090671721709568

Some of the seeming regressions must be because of flakiness. But is there any regression in there that is plausibly related to scrollbars?

@foolip
Copy link
Member

foolip commented Feb 13, 2025

https://wpt.fyi/results/?q=is%3Adifferent%20scroll&run_id=5089997478952960&run_id=5090671721709568 is promising, among tests with "scroll" in the name there are only progressions, no regressions.

Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flackr feel free to merge if you see nothing of concern in that diff

@foolip
Copy link
Member

foolip commented Feb 13, 2025

Hmm, so the set_get_window_rect.html failure in infrastructure tests will block landing this. But it looks like that failure was in Firefox, and maybe preexisting then?

@past have you seen this blocking other PRs?

@past
Copy link
Member

past commented Feb 13, 2025

Hmm, so the set_get_window_rect.html failure in infrastructure tests will block landing this. But it looks like that failure was in Firefox, and maybe preexisting then?

@past have you seen this blocking other PRs?

I hadn't seen this before, but it seems to be a recent failure, unrelated to this PR.

@flackr
Copy link
Contributor Author

flackr commented Feb 19, 2025

@foolip @past what do we need to do to get this unblocked?

@past past closed this Feb 19, 2025
@past past reopened this Feb 19, 2025
@past
Copy link
Member

past commented Feb 19, 2025

Given that the change is only impacting Chrome, the check failures seem unrelated. It's up to Philip since he started reviewing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants