Ref count tests and others #50597
Draft
Ref count tests and others #50597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domfarolino
reviewed
Feb 10, 2025
domfarolino
requested changes
Feb 10, 2025
| const target = new EventTarget(); | ||
|
|
||
|
|
||
| }, "ref-counted event target should not be re-entrant") |
There was a problem hiding this comment.
Weird... sorry, I was in an airport... I'll clean this up. (This is why it's a "draft") haha
|
Just a heads up, this is a draft right now, I only added two or three tests to the observable-constructor tests, but on airport wifi I couldn't get the latest upstream to rebase on. :) I'll clean it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a start... @domfarolino I just wanted to get your attention here. There might be more tests we can come up with, but here's a start.
Included are some ref counting tests, and also tests that ensure teardown always happens before complete or error is notified. (this sort of relates to
finallyas well)