[WIP] WebDriverTestharnessExecutor bidi/classic decision #50626
+49
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadym-chromium
changed the title
sadym-chromium
force-pushed
the
sadym/WebDriverTestharnessExecutor-bidi
branch
from
744ac48 to
3665bc9
Compare
sadym-chromium
force-pushed
the
sadym/WebDriverTestharnessExecutor-bidi
branch
from
3665bc9 to
a978c1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #50546.
Move decision on whether enable or not WebDriver BiDi to WebDriverTestharnessExecutor. Executors can specify the protocol by overriding
protocol_cls. If the protocol instance do not implement WebDriver BiDi, fail with an error.