Test removing a sibling element when both are fullscreen #50630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests complements the existing remove-first.html and remove-last.html tests where the two elements in top layer have a parent-child relationship. These test instead have two sibling elements, and removes one of them. This is important because remove-first.html actually removes both elements. The remove-last-sibling.html isn't as novel but is tested for completeness sake.
foolip
force-pushed
the
fullscreen-remove-siblings
branch
from
57d41d4 to
e9654b4
Compare
nt1m
approved these changes
Feb 11, 2025
Co-authored-by: Tim Nguyen <nt1m@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests complements the existing remove-first.html and remove-last.html
tests where the two elements in top layer have a parent-child
relationship. These test instead have two sibling elements, and removes
one of them. This is important because remove-first.html actually
removes both elements. The remove-last-sibling.html isn't as novel but
is tested for completeness sake.