Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder showing wrong format for country code Malaysia(my) #350

Open
faizaldong opened this issue Dec 9, 2020 · 2 comments
Open

Placeholder showing wrong format for country code Malaysia(my) #350

faizaldong opened this issue Dec 9, 2020 · 2 comments

Comments

@faizaldong
Copy link

faizaldong commented Dec 9, 2020

Hi maintainer.

Need request from your side to update placeholder and format number for country malaysia
Screenshot 2020-12-09 at 5 15 47 PM

Basically number format for Malaysia without dash " - "

can you change the placeholder to this 60 12385 6789 instead?

thanks!

@pasevin
Copy link
Collaborator

pasevin commented Mar 9, 2021

We are using google-libphonenumber to get the number placeholders. We probably need to use the latest library, but it doesn't guarantee that the placeholder will be correct, as it all depends on the creators.

Another solution for us would be to create @Output() for when the country changes, and then the user could hook it up with already existing customPlaceholder property to set dynamically "amended" placeholder. This way we allow users more flexibility, but at the same time, it would involve more work.

@faizaldong
Copy link
Author

It would be better if your library can give more flexibility to user. Anyway thank you for the effort. Hope I can get update for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants