Add popup container & popup placement selector functionality #391
Conversation
|
Why is this not being reviewed? this PR is getting way too OLD! |
| "google-libphonenumber": "^3.2.3", | ||
| "intl-tel-input": "^17.0.3", | ||
| "ngx-bootstrap": "^6.0.0" | ||
| "@angular/common": "^12.1.4", |
There was a problem hiding this comment.
i assume there are way too many version changes here, more than are required to get this change to work?
| iso2: '', | ||
| name: '', | ||
| placeHolder: '', | ||
| dialCode: "", |
There was a problem hiding this comment.
Many personal code style choices being applied, are these linting rules active in the library?
| [selectFirstCountry]="false" | ||
| [selectedCountryISO]="CountryISO.India" | ||
| [maxLength]="15" | ||
| [phoneValidation]="true" | ||
| [separateDialCode]="separateDialCode" | ||
| [numberFormat]="PhoneNumberFormat.National" | ||
| [searchCountryPopupContainer]=" |
There was a problem hiding this comment.
great addition to the package. i'm looking forward to seeing this merged soon
|
@webcat12345 Can we get some eyes on this PR please? |
|
Sorry guys, I am going to take it look today!
Again, sorry for delay.
…On Wed, Aug 3, 2022 at 5:07 PM Sebastian Scholle ***@***.***> wrote:
@webcat12345 <https://github.com/webcat12345> Can we get some eyes on
this PR please?
—
Reply to this email directly, view it on GitHub
<#391 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEWYSDUXAHTLGMKTDP44YFLVXISDDANCNFSM46YVUD4Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi @webcat12345 could you please look at this PR? |
cmckni3
changed the title
Added 2 additional input properties to fix my issue: #388
It would be better if we could add a class to the ngx dropdown element, but that doesn't seem possible yet, so I've added the .iti class to the .country-dropdown element to fix some css.