Skip to content

Closed, see note in body: Reimplement transformation, handle Meta Nodes interrupting vertex grouping #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

webdevred
Copy link
Owner

@webdevred webdevred commented Jun 1, 2025

Closed due to weird timeline caused by doing Git when being hungry. Development will continue in #2

This update improves the way jbeam_edit processes meta nodes (such as {"group":"..."}) that interrupt vertex groupings within .jbeam files. Previously, encountering these meta nodes resulted in an explicit error message indicating unsupported input, preventing further processing.

Key changes:

  • Extract all vertices from sections interrupted by meta nodes.
  • Sort vertices within their respective groups while preserving the original order relative to meta nodes.
  • Move and reinsert vertices back into their original nodes, maintaining file structure integrity.
  • Enhance logic to gracefully handle meta nodes interrupting vertex lists.

Example of the previous grouping logic being broken by meta nodes:

{"group": "group1"}
["fr0", -0.426, -2.084, 0.235]
["fr1", 0.487, -2.072, 0.235]
{"group": "group2"}
["fr2", -0.418, -2.034, 0.300]

With this update, jbeam_edit properly handles such cases by treating meta nodes as separators, allowing vertices to be grouped and sorted correctly within their respective groups.

@webdevred webdevred force-pushed the new_transformation branch 15 times, most recently from 1f3b62d to 8a2cbb2 Compare June 1, 2025 13:08
@webdevred webdevred force-pushed the new_transformation branch from 8a2cbb2 to e536965 Compare June 1, 2025 13:09
@webdevred webdevred force-pushed the new_transformation branch 4 times, most recently from 7e42396 to b88675e Compare June 1, 2025 13:21
@webdevred webdevred force-pushed the master branch 3 times, most recently from 2b0dd86 to 102caab Compare June 1, 2025 13:37
@webdevred webdevred force-pushed the new_transformation branch from b88675e to c353a99 Compare June 1, 2025 13:39
@webdevred webdevred force-pushed the master branch 4 times, most recently from ca36088 to 0692a42 Compare June 1, 2025 14:12
@webdevred webdevred force-pushed the master branch 4 times, most recently from 7771e43 to ba68e4f Compare June 1, 2025 14:34
@webdevred webdevred force-pushed the new_transformation branch from c353a99 to 5d40fac Compare June 1, 2025 14:36
@webdevred webdevred closed this Jun 1, 2025
Repository owner locked as resolved and limited conversation to collaborators Jun 1, 2025
@webdevred webdevred changed the title Reimplement transformation, handle Meta Nodes interrupting vertex grouping Closed, see note in body: Reimplement transformation, handle Meta Nodes interrupting vertex grouping Jun 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant